DescriptionRevert of Add new test: DownloadTest.TestMultipleDownloadsBubble (patchset #2 id:40001 of https://codereview.chromium.org/976823002/)
Reason for revert:
New test added is flaky. Sorry. :)
https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/21829
[ RUN ] DownloadTest.TestMultipleDownloadsBubble
[3840:2828:0303/224822:WARNING:data_reduction_proxy_config.cc(240)] SPDY proxy OFF at startup
HTTP server started on http://127.0.0.1:54250...
sending server_data: {"host": "127.0.0.1", "port": 54250} (36 bytes)
c:\b\build\slave\win_x64_builder\build\src\chrome\browser\download\download_browsertest.cc(2974): error: Value of: mock_bubble_view->IsVisible()
Actual: false
Expected: true
Original issue's description:
> Add new test: DownloadTest.TestMultipleDownloadsBubble
>
> This ensures that both infobars and bubbles are tested by creating both
> DownloadTest.TestMultipleDownloadsInfobar and DownloadTest.
> TestMultipleDownloadsBubble. The correct UI (infobar or bubble) is
> forced with a switch.
>
> BUG=438758
>
> Committed: https://crrev.com/ff5eb76821e76cb6c90b940249caf3d748e6fbc0
> Cr-Commit-Position: refs/heads/master@{#318987}
TBR=asanka@chromium.org,felt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=438758
Committed: https://crrev.com/ee5572d955d101e78b19a1a8f68a0f072050b4b7
Cr-Commit-Position: refs/heads/master@{#319037}
Patch Set 1 #
Created: 5 years, 9 months ago
(Patch set is too large to download)
Messages
Total messages: 6 (0 generated)
|