Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 977863002: Revert of Add new test: DownloadTest.TestMultipleDownloadsBubble (Closed)

Created:
5 years, 9 months ago by Finnur
Modified:
5 years, 9 months ago
Reviewers:
asanka, felt
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add new test: DownloadTest.TestMultipleDownloadsBubble (patchset #2 id:40001 of https://codereview.chromium.org/976823002/) Reason for revert: New test added is flaky. Sorry. :) https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/21829 [ RUN ] DownloadTest.TestMultipleDownloadsBubble [3840:2828:0303/224822:WARNING:data_reduction_proxy_config.cc(240)] SPDY proxy OFF at startup HTTP server started on http://127.0.0.1:54250... sending server_data: {"host": "127.0.0.1", "port": 54250} (36 bytes) c:\b\build\slave\win_x64_builder\build\src\chrome\browser\download\download_browsertest.cc(2974): error: Value of: mock_bubble_view->IsVisible() Actual: false Expected: true Original issue's description: > Add new test: DownloadTest.TestMultipleDownloadsBubble > > This ensures that both infobars and bubbles are tested by creating both > DownloadTest.TestMultipleDownloadsInfobar and DownloadTest. > TestMultipleDownloadsBubble. The correct UI (infobar or bubble) is > forced with a switch. > > BUG=438758 > > Committed: https://crrev.com/ff5eb76821e76cb6c90b940249caf3d748e6fbc0 > Cr-Commit-Position: refs/heads/master@{#318987} TBR=asanka@chromium.org,felt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=438758 Committed: https://crrev.com/ee5572d955d101e78b19a1a8f68a0f072050b4b7 Cr-Commit-Position: refs/heads/master@{#319037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -52 lines) Patch
M chrome/browser/download/download_browsertest.cc View 3 chunks +0 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Finnur
Created Revert of Add new test: DownloadTest.TestMultipleDownloadsBubble
5 years, 9 months ago (2015-03-04 08:53:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977863002/1
5 years, 9 months ago (2015-03-04 08:53:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 08:54:17 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ee5572d955d101e78b19a1a8f68a0f072050b4b7 Cr-Commit-Position: refs/heads/master@{#319037}
5 years, 9 months ago (2015-03-04 08:55:36 UTC) #4
felt
On 2015/03/04 08:55:36, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 9 months ago (2015-03-04 18:15:53 UTC) #5
Finnur
5 years, 9 months ago (2015-03-05 10:33:48 UTC) #6
Message was sent while issue was closed.
Yeah, I empathize with you. Super frustrating. :)

Powered by Google App Engine
This is Rietveld 408576698