gpu/command_buffer/service/texture_definition.cc - Issue 977853002: Reland of Revert of gpu: introduce glCopySubTextureCHROMIUM (patchset #1 id:1 of https://codereview…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/texture_definition.cc

Issue 977853002: Reland of Revert of gpu: introduce glCopySubTextureCHROMIUM (patchset #1 id:1 of https://codereview… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Apply image optimization to CopySubTexture. move glValidateProgram Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/gles2_cmd_decoder.cc ('K') | « gpu/command_buffer/service/stream_texture_manager_in_process_android.cc ('k') | gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc » ('j') | ui/gl/gl_image.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/texture_definition.cc

diff --git a/gpu/command_buffer/service/texture_definition.cc b/gpu/command_buffer/service/texture_definition.cc

index f2091b557bd7c2f505a53db92e7f6c31c39790fa..ea23ff6428f40343be53c9aaea57f88c807020d7 100644

--- a/gpu/command_buffer/service/texture_definition.cc

+++ b/gpu/command_buffer/service/texture_definition.cc

@@ -33,7 +33,7 @@ class GLImageSync : public gfx::GLImage {

gfx::Size GetSize() override;

bool BindTexImage(unsigned target) override;

void ReleaseTexImage(unsigned target) override;

- bool CopyTexImage(unsigned target) override;

+ bool CopyTexSubImage(unsigned target, int xoffset, int yoffset) override;

void WillUseTexImage() override;

void WillModifyTexImage() override;

void DidModifyTexImage() override;

@@ -82,7 +82,7 @@ void GLImageSync::ReleaseTexImage(unsigned target) {

NOTREACHED();

}

-bool GLImageSync::CopyTexImage(unsigned target) {

+bool GLImageSync::CopyTexSubImage(unsigned target, int xoffset, int yoffset) {

return false;

}