Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 977763002: Remove deprecated extension notification from ImageLoaderTest (Closed)

Created:
5 years, 9 months ago by limasdf
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated extension notification from ImageLoaderTest R=kalman@chromium.org BUG=354046 TEST=extensions_unittests Committed: https://crrev.com/945ae751622fdeb302b318904cdf192f6de1ee7e Cr-Commit-Position: refs/heads/master@{#319144}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M extensions/browser/image_loader_unittest.cc View 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
limasdf
PTAL. tests pass! Exactly same change with previous one we talk yesterday. I clicked "discard" ...
5 years, 9 months ago (2015-03-04 10:05:39 UTC) #1
not at google - send to devlin
lgtm
5 years, 9 months ago (2015-03-04 17:36:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977763002/1
5 years, 9 months ago (2015-03-04 22:10:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 22:39:28 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 22:40:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/945ae751622fdeb302b318904cdf192f6de1ee7e
Cr-Commit-Position: refs/heads/master@{#319144}

Powered by Google App Engine
This is Rietveld 408576698