Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 977663004: Use tiles when encoding with VP9. (Closed)

Created:
5 years, 9 months ago by aconverse
Modified:
5 years, 9 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use tiles when encoding with VP9. VP9's tile encoding feature allows for multithreaded parallelism on both the encoder and decoder side. TEST=Run remoting_perftests under VTune and see that two logical CPUs are used BUG=134202 Committed: https://crrev.com/e67fefbf4f5a5a83ca8d487f422b09664dc4c8fe Cr-Commit-Position: refs/heads/master@{#319167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M remoting/codec/video_encoder_vpx.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
aconverse
5 years, 9 months ago (2015-03-04 21:09:53 UTC) #1
Wez
lgtm
5 years, 9 months ago (2015-03-04 21:23:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977663004/1
5 years, 9 months ago (2015-03-04 21:24:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 00:12:06 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e67fefbf4f5a5a83ca8d487f422b09664dc4c8fe Cr-Commit-Position: refs/heads/master@{#319167}
5 years, 9 months ago (2015-03-05 00:12:29 UTC) #7
aconverse
5 years, 9 months ago (2015-03-05 01:05:10 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/978133002/ by aconverse@chromium.org.

The reason for reverting is: Breaks linux valgrind,
needs libvpx side fixes and roll,
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28v....

Powered by Google App Engine
This is Rietveld 408576698