Plugin Power Saver: Accept SPACE or ENTER to unthrottle plugins.

Plugin Power Saver: Accept SPACE or ENTER to unthrottle plugins.

Enhances accessibility of throttled plugins.

This enables these steps:
1. Using ChromeVox, focus throttled plugin using Alt+Shift+Arrow Keys.
2. Press ENTER or SPACE.

BUG=458285
Committed: https://crrev.com/ea2d9501621379d11e67d62a830af7d4f311390e
Cr-Commit-Position: refs/heads/master@{#318951}

[tommycli, 2015-03-03 19:45:14]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2015-03-03 19:45:14]

dbeam: PTAL. This works on my local machine using ChromeVox.

Not sure if I'm missing something or if the implementation is too ghetto.

Thanks!

[Dan Beam, 2015-03-03 19:51:51]

do key events flow up from the <object>?

https://codereview.chromium.org/977653002/diff/1/chrome/renderer/resources/pl...
File chrome/renderer/resources/plugin_poster.html (right):

https://codereview.chromium.org/977653002/diff/1/chrome/renderer/resources/pl...
chrome/renderer/resources/plugin_poster.html:12: document.onkeypress =
function(e) {
nit: maybe do this onkeydown instead

https://codereview.chromium.org/977653002/diff/1/chrome/renderer/resources/pl...
chrome/renderer/resources/plugin_poster.html:13: if (e.keyCode == 13 ||
e.keyCode == 32) {
nit: e.keyIdentifier == 'Enter' || e.keyIdentifier == 'U+0020'

https://codereview.chromium.org/977653002/diff/1/chrome/renderer/resources/pl...
chrome/renderer/resources/plugin_poster.html:14: plugin.load();
e.preventDefault();

https://codereview.chromium.org/977653002/diff/1/chrome/renderer/resources/pl...
chrome/renderer/resources/plugin_poster.html:15: }
nit: no curlies

[tommycli, 2015-03-03 20:02:00]

dbeam: thanks!

https://codereview.chromium.org/977653002/diff/1/chrome/renderer/resources/pl...
File chrome/renderer/resources/plugin_poster.html (right):

https://codereview.chromium.org/977653002/diff/1/chrome/renderer/resources/pl...
chrome/renderer/resources/plugin_poster.html:12: document.onkeypress =
function(e) {
On 2015/03/03 19:51:51, Dan Beam wrote:
> nit: maybe do this onkeydown instead

Done.

https://codereview.chromium.org/977653002/diff/1/chrome/renderer/resources/pl...
chrome/renderer/resources/plugin_poster.html:13: if (e.keyCode == 13 ||
e.keyCode == 32) {
On 2015/03/03 19:51:51, Dan Beam wrote:
> nit: e.keyIdentifier == 'Enter' || e.keyIdentifier == 'U+0020'

Done.

https://codereview.chromium.org/977653002/diff/1/chrome/renderer/resources/pl...
chrome/renderer/resources/plugin_poster.html:14: plugin.load();
On 2015/03/03 19:51:51, Dan Beam wrote:
> e.preventDefault();

Done.

https://codereview.chromium.org/977653002/diff/1/chrome/renderer/resources/pl...
chrome/renderer/resources/plugin_poster.html:15: }
On 2015/03/03 19:51:51, Dan Beam wrote:
> nit: no curlies

Added back due to adding e.preventDefault().

[Dan Beam, 2015-03-03 20:11:53]

lgtm

[tommycli, 2015-03-03 20:37:26]

tommycli@chromium.org changed reviewers:
+ thestig@chromium.org

[tommycli, 2015-03-03 20:37:44]

thestig: May i have an OWNERs stamp? thanks!

[Lei Zhang, 2015-03-03 21:19:56]

lgtm

[tommycli, 2015-03-03 22:02:30]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2015-03-03 22:04:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/977653002/40001

[commit-bot: I haz the power, 2015-03-03 22:43:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-03 22:44:33]

Patchset 3 (id:??) landed as
https://crrev.com/ea2d9501621379d11e67d62a830af7d4f311390e
Cr-Commit-Position: refs/heads/master@{#318951}