Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 977603002: gn: Cleanup - Sort GYP sources list alphabetical. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Cleanup - Sort GYP sources list alphabetical. This was generated using the following command line: $ tools/sort_sources.py tools/gn/gn.gyp BUG=None R=scottmg@chromium.org Committed: https://crrev.com/042e01c7e580150ae950fd5576cd4ff6b3c02d2e Cr-Commit-Position: refs/heads/master@{#319137}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M tools/gn/gn.gyp View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
tfarina
5 years, 9 months ago (2015-03-03 17:56:16 UTC) #1
scottmg
lgtm
5 years, 9 months ago (2015-03-03 19:05:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977603002/1
5 years, 9 months ago (2015-03-03 19:06:54 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/15940)
5 years, 9 months ago (2015-03-03 22:33:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977603002/1
5 years, 9 months ago (2015-03-03 22:34:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/16036)
5 years, 9 months ago (2015-03-04 01:43:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977603002/20001
5 years, 9 months ago (2015-03-04 01:48:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/16143)
5 years, 9 months ago (2015-03-04 04:52:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977603002/20001
5 years, 9 months ago (2015-03-04 13:45:14 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/16324)
5 years, 9 months ago (2015-03-04 17:40:00 UTC) #19
scottmg
On 2015/03/04 17:40:00, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-03-04 20:45:52 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977603002/20001
5 years, 9 months ago (2015-03-04 21:35:52 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 22:09:37 UTC) #23
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 22:10:15 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/042e01c7e580150ae950fd5576cd4ff6b3c02d2e
Cr-Commit-Position: refs/heads/master@{#319137}

Powered by Google App Engine
This is Rietveld 408576698