Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11529)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 977573002: content: Add an overridable task runner to ChildThreadImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move GetTaskRunner back to the RenderThread. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | content/renderer/render_thread_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 0291a86cfbc8b94d9ade4a3367ad520b552a1da0..2298b4017005769a6d9c38239684045ffaabe21f 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -432,30 +432,43 @@ RenderThreadImpl* RenderThreadImpl::current() {
// When we run plugins in process, we actually run them on the render thread,
// which means that we need to make the render thread pump UI events.
-RenderThreadImpl::RenderThreadImpl()
- : ChildThreadImpl(Options::Builder()
- .InBrowserProcess(true)
- .UseMojoChannel(ShouldUseMojoChannel())
- .Build()) {
+RenderThreadImpl::RenderThreadImpl(
+ scoped_ptr<RendererScheduler> renderer_scheduler)
+ : ChildThreadImpl(
+ Options::Builder()
+ .InBrowserProcess(true)
+ .UseMojoChannel(ShouldUseMojoChannel())
+ .WithTaskRunner(renderer_scheduler->DefaultTaskRunner())
+ .Build()),
+ renderer_scheduler_(renderer_scheduler.Pass()) {
Init();
}
-RenderThreadImpl::RenderThreadImpl(const std::string& channel_name)
- : ChildThreadImpl(Options::Builder()
- .InBrowserProcess(true)
- .UseMojoChannel(ShouldUseMojoChannel())
- .WithChannelName(channel_name)
- .Build()) {
+RenderThreadImpl::RenderThreadImpl(
+ const std::string& channel_name,
+ scoped_ptr<RendererScheduler> renderer_scheduler)
+ : ChildThreadImpl(
+ Options::Builder()
+ .InBrowserProcess(true)
+ .UseMojoChannel(ShouldUseMojoChannel())
+ .WithChannelName(channel_name)
+ .WithTaskRunner(renderer_scheduler->DefaultTaskRunner())
+ .Build()),
+ renderer_scheduler_(renderer_scheduler.Pass()) {
Init();
}
RenderThreadImpl::RenderThreadImpl(
- scoped_ptr<base::MessageLoop> main_message_loop)
- : ChildThreadImpl(Options::Builder()
- // TODO(skyostil): This should be set to false.
- .InBrowserProcess(true)
- .UseMojoChannel(ShouldUseMojoChannel())
- .Build()),
+ scoped_ptr<base::MessageLoop> main_message_loop,
+ scoped_ptr<RendererScheduler> renderer_scheduler)
+ : ChildThreadImpl(
+ Options::Builder()
+ // TODO(skyostil): This should be set to false.
+ .InBrowserProcess(true)
+ .UseMojoChannel(ShouldUseMojoChannel())
+ .WithTaskRunner(renderer_scheduler->DefaultTaskRunner())
+ .Build()),
+ renderer_scheduler_(renderer_scheduler.Pass()),
main_message_loop_(main_message_loop.Pass()) {
Init();
}
@@ -492,7 +505,6 @@ void RenderThreadImpl::Init() {
dom_storage_dispatcher_.reset(new DomStorageDispatcher());
main_thread_indexed_db_dispatcher_.reset(new IndexedDBDispatcher(
thread_safe_sender()));
- renderer_scheduler_ = RendererScheduler::Create();
channel()->SetListenerTaskRunner(renderer_scheduler_->DefaultTaskRunner());
embedded_worker_dispatcher_.reset(new EmbeddedWorkerDispatcher());
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | content/renderer/render_thread_impl_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698