Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: content/browser/devtools/protocol/page_handler.cc

Issue 977553003: DevTools: remove usage and quota getter from the protocol handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@946713002
Patch Set: removed the test. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/page_handler.cc
diff --git a/content/browser/devtools/protocol/page_handler.cc b/content/browser/devtools/protocol/page_handler.cc
index 127a797829275c6aa86e9082b0fffc50027c1541..356cefa580e011268593f79615d006c3c3289773 100644
--- a/content/browser/devtools/protocol/page_handler.cc
+++ b/content/browser/devtools/protocol/page_handler.cc
@@ -13,7 +13,6 @@
#include "base/threading/worker_pool.h"
#include "content/browser/devtools/protocol/color_picker.h"
#include "content/browser/devtools/protocol/frame_recorder.h"
-#include "content/browser/devtools/protocol/usage_and_quota_query.h"
#include "content/browser/geolocation/geolocation_service_context.h"
#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_view_base.h"
@@ -27,7 +26,6 @@
#include "content/public/browser/web_contents_delegate.h"
#include "content/public/common/referrer.h"
#include "content/public/common/url_constants.h"
-#include "storage/browser/quota/quota_manager.h"
#include "third_party/WebKit/public/platform/WebScreenInfo.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/base/page_transition_types.h"
@@ -65,24 +63,6 @@ ui::GestureProviderConfigType TouchEmulationConfigurationToType(
return result;
}
-void QueryUsageAndQuotaCompletedOnIOThread(
- const UsageAndQuotaQuery::Callback& callback,
- scoped_refptr<QueryUsageAndQuotaResponse> response) {
- BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
- base::Bind(callback, response));
-}
-
-void QueryUsageAndQuotaOnIOThread(
- scoped_refptr<storage::QuotaManager> quota_manager,
- const GURL& security_origin,
- const UsageAndQuotaQuery::Callback& callback) {
- new UsageAndQuotaQuery(
- quota_manager,
- security_origin,
- base::Bind(&QueryUsageAndQuotaCompletedOnIOThread,
- callback));
-}
-
std::string EncodeScreencastFrame(const SkBitmap& bitmap,
const std::string& format,
int quality) {
@@ -449,21 +429,6 @@ Response PageHandler::HandleJavaScriptDialog(bool accept,
Response PageHandler::QueryUsageAndQuota(DevToolsCommandId command_id,
const std::string& security_origin) {
- if (!host_)
- return Response::InternalError("Could not connect to view");
-
- scoped_refptr<storage::QuotaManager> quota_manager =
- host_->GetProcess()->GetStoragePartition()->GetQuotaManager();
-
- BrowserThread::PostTask(
- BrowserThread::IO,
- FROM_HERE,
- base::Bind(&QueryUsageAndQuotaOnIOThread,
- quota_manager,
- GURL(security_origin),
- base::Bind(&PageHandler::QueryUsageAndQuotaCompleted,
- weak_factory_.GetWeakPtr(),
- command_id)));
return Response::OK();
}
@@ -634,12 +599,6 @@ void PageHandler::OnFramesRecorded(
client_->SendStopRecordingFramesResponse(command_id, response_data);
}
-void PageHandler::QueryUsageAndQuotaCompleted(
- DevToolsCommandId command_id,
- scoped_refptr<QueryUsageAndQuotaResponse> response_data) {
- client_->SendQueryUsageAndQuotaResponse(command_id, response_data);
-}
-
} // namespace page
} // namespace devtools
} // namespace content
« no previous file with comments | « content/browser/devtools/protocol/page_handler.h ('k') | content/browser/devtools/protocol/usage_and_quota_query.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698