Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 977553003: DevTools: remove usage and quota getter from the protocol handler. (Closed)

Created:
5 years, 9 months ago by pfeldman
Modified:
5 years, 9 months ago
Reviewers:
lushnikov
CC:
aandrey+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, pfeldman, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@946713002
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove usage and quota getter from the protocol handler. Committed: https://crrev.com/4f95078309b3d1091049b1590304f4441f4498b2 Cr-Commit-Position: refs/heads/master@{#319026}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : removed the test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -216 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 1 2 5 chunks +0 lines, -41 lines 0 comments Download
D content/browser/devtools/protocol/usage_and_quota_query.h View 1 chunk +0 lines, -63 lines 0 comments Download
D content/browser/devtools/protocol/usage_and_quota_query.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
pfeldman
5 years, 9 months ago (2015-03-03 15:12:59 UTC) #2
lushnikov
lgtm
5 years, 9 months ago (2015-03-03 15:21:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977553003/40001
5 years, 9 months ago (2015-03-03 15:29:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/31768)
5 years, 9 months ago (2015-03-03 19:00:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977553003/60001
5 years, 9 months ago (2015-03-04 06:56:56 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-04 07:45:10 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 07:46:02 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4f95078309b3d1091049b1590304f4441f4498b2
Cr-Commit-Position: refs/heads/master@{#319026}

Powered by Google App Engine
This is Rietveld 408576698