Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 977543002: [es6] Fix for-const loops (Closed)

Created:
5 years, 9 months ago by rossberg
Modified:
5 years, 9 months ago
CC:
v8-dev, ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix for-const loops R=dslomov@chromium.org BUG=v8:3983 LOG=Y Committed: https://crrev.com/054989bd04f9bb4e73e2c243dfb48ebd3ac048e7 Cr-Commit-Position: refs/heads/master@{#26971}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -27 lines) Patch
M src/parser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parser.cc View 8 chunks +22 lines, -19 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-3938.js View 1 chunk +3 lines, -5 lines 1 comment Download
M test/mjsunit/harmony/block-const-assign.js View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
rossberg
5 years, 9 months ago (2015-03-03 13:50:56 UTC) #1
Dmitry Lomov (no reviews)
lgtm % test https://codereview.chromium.org/977543002/diff/1/test/mjsunit/es6/regress/regress-3938.js File test/mjsunit/es6/regress/regress-3938.js (right): https://codereview.chromium.org/977543002/diff/1/test/mjsunit/es6/regress/regress-3938.js#newcode7 test/mjsunit/es6/regress/regress-3938.js:7: assertThrows(function() { for (const i = ...
5 years, 9 months ago (2015-03-03 15:13:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977543002/1
5 years, 9 months ago (2015-03-03 18:07:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 18:34:34 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 18:34:51 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/054989bd04f9bb4e73e2c243dfb48ebd3ac048e7
Cr-Commit-Position: refs/heads/master@{#26971}

Powered by Google App Engine
This is Rietveld 408576698