Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 977493002: Fix crash when syncing files on Drive. (Closed)

Created:
5 years, 9 months ago by mtomasz
Modified:
5 years, 9 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, tfarina, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when syncing files on Drive. A recent CL caused a crash due to undefined order of evaluating arguments in C++. An invalid pointer was causing a crash on G++ builds only. TEST=Tested manually on a Chromebook. BUG=462999 Committed: https://crrev.com/120c67c5b4f8f87a3dbbf58043fc36532568bc70 Cr-Commit-Position: refs/heads/master@{#318857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 5 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtomasz
@hashimoto: PTAL. Thanks.
5 years, 9 months ago (2015-03-03 08:29:27 UTC) #2
hashimoto
lgtm
5 years, 9 months ago (2015-03-03 08:42:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977493002/1
5 years, 9 months ago (2015-03-03 08:43:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 09:30:46 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 09:31:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/120c67c5b4f8f87a3dbbf58043fc36532568bc70
Cr-Commit-Position: refs/heads/master@{#318857}

Powered by Google App Engine
This is Rietveld 408576698