chrome/browser/browser_resources.grd - Issue 977473002: downloads: break downloads.js into more classes/files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_resources.grd

Issue 977473002: downloads: break downloads.js into more classes/files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asanka@ review Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/download/download_item_model.h » ('j') | chrome/browser/resources/downloads/downloads.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browser_resources.grd

diff --git a/chrome/browser/browser_resources.grd b/chrome/browser/browser_resources.grd

index 0bb67a89f41c5c2a7e3fd67c2f0c38f46bcdbf75..b9b425dee35a343990d4b218271df7d360fb5068 100644

--- a/chrome/browser/browser_resources.grd

+++ b/chrome/browser/browser_resources.grd

@@ -129,7 +129,10 @@

- <include name="IDR_DOWNLOADS_JS" file="resources\downloads\downloads.js" type="BINDATA" />

+ <include name="IDR_DOWNLOAD_ITEM_JS" file="resources\downloads\item.js" type="BINDATA" />

+ <include name="IDR_DOWNLOAD_ITEM_VIEW_JS" file="resources\downloads\item_view.js" type="BINDATA" />

+ <include name="IDR_DOWNLOAD_FOCUS_ROW_JS" file="resources\downloads\focus_row.js" type="BINDATA" />

Lei Zhang 2015/03/11 23:01:38 Alphabetical order? What about externs.js?

Dan Beam 2015/03/11 23:38:34 whoops. Done. (they were in dependency order...

+ <include name="IDR_DOWNLOAD_MANAGER_JS" file="resources\downloads\manager.js" type="BINDATA" />

</if>

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/download/download_item_model.h » ('j') | chrome/browser/resources/downloads/downloads.html » ('J')