chrome/app/generated_resources.grd - Issue 977473002: downloads: break downloads.js into more classes/files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 977473002: downloads: break downloads.js into more classes/files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove NOTREACHED for testing code Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index e698d4f4ac551d4eb523822ef74d96c0c2e5abf9..f966ff9a8d90e9f270bae6f9fb4883527bca55c1 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -2061,7 +2061,7 @@ Even if you have downloaded files from this website before, the website might ha

</message>

<message name="IDS_DOWNLOAD_BY_EXTENSION"

desc="Indicates which extension downloaded this file.">

- Downloaded by <ph name="EXTENSION">$1<ex>The Best Chrome Extension Ever</ex></ph>

+ Downloaded by <a href="<ph name="EXTENSION_URL">$1</ph>"><ph name="EXTENSION">$2<ex>The Best Chrome Extension Ever</ex></ph></a>

asanka 2015/03/10 04:15:50 Note to self: Make sure EXTENSION_URL is adequatel

Dan Beam 2015/03/10 05:41:02 Done.

</message>

« no previous file with comments | « no previous file | chrome/browser/browser_resources.grd » ('j') | chrome/browser/resources/downloads/externs.js » ('J')