Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: net/quic/quic_unacked_packet_map.cc

Issue 977453002: Discard acks from QUIC's UnackedPacketMap when the map is larger than (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Remove_TCP_and_BBR_max_congestion_window_87346681
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_unacked_packet_map_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_unacked_packet_map.cc
diff --git a/net/quic/quic_unacked_packet_map.cc b/net/quic/quic_unacked_packet_map.cc
index c2b6fec8fbc095ee807e5b79ff4169c727816cf3..5f29a2b3c3b9d0434afce257eed1a2a7c30d3c4c 100644
--- a/net/quic/quic_unacked_packet_map.cc
+++ b/net/quic/quic_unacked_packet_map.cc
@@ -13,14 +13,6 @@ using std::max;
namespace net {
-namespace {
-
-// Maximum amount of reordering before packets are considered useless for
-// RTT measurement purposes.
-const QuicPacketCount kMaxReorderingForRtt = 200;
-
-} // anonymous namespace
-
QuicUnackedPacketMap::QuicUnackedPacketMap()
: largest_sent_packet_(0),
largest_observed_(0),
@@ -281,7 +273,7 @@ bool QuicUnackedPacketMap::IsPacketRemovable(
QuicPacketSequenceNumber sequence_number,
const TransmissionInfo& info) const {
return (!IsPacketUsefulForMeasuringRtt(sequence_number, info) ||
- unacked_packets_.size() > kMaxReorderingForRtt) &&
+ unacked_packets_.size() > kMaxTrackedPackets / 2) &&
!IsPacketUsefulForCongestionControl(info) &&
!IsPacketUsefulForRetransmittableData(info);
}
« no previous file with comments | « no previous file | net/quic/quic_unacked_packet_map_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698