Chromecast Android: pass ICU file descriptor to render process.

Chromecast Android: pass ICU file descriptor to render process.

R=lcwu@chromium.org,halliwell@chromium.org
BUG=internal b/19559717

Committed: https://crrev.com/568f43629db2ee7c2121adf576c21e06554d5c2e
Cr-Commit-Position: refs/heads/master@{#319079}

[halliwell, 2015-03-03 02:26:28]

lgtm

https://codereview.chromium.org/977443002/diff/1/chromecast/browser/cast_cont...
File chromecast/browser/cast_content_browser_client.cc (right):

https://codereview.chromium.org/977443002/diff/1/chromecast/browser/cast_cont...
chromecast/browser/cast_content_browser_client.cc:277: int flags_open_read =
base::File::FLAG_OPEN | base::File::FLAG_READ;
const int

[gunsch, 2015-03-03 02:30:41]

https://codereview.chromium.org/977443002/diff/1/chromecast/browser/cast_cont...
File chromecast/browser/cast_content_browser_client.cc (right):

https://codereview.chromium.org/977443002/diff/1/chromecast/browser/cast_cont...
chromecast/browser/cast_content_browser_client.cc:277: int flags_open_read =
base::File::FLAG_OPEN | base::File::FLAG_READ;
On 2015/03/03 02:26:28, halliwell wrote:
> const int

Done.

[lcwu1, 2015-03-04 01:18:52]

lgtm % style consistency nit

https://codereview.chromium.org/977443002/diff/20001/chromecast/browser/cast_...
File chromecast/browser/cast_content_browser_client.cc (right):

https://codereview.chromium.org/977443002/diff/20001/chromecast/browser/cast_...
chromecast/browser/cast_content_browser_client.cc:287:
base::ScopedFD(pak_with_flags.TakePlatformFile()));
I think it would be cleaner if the code in line 281-287 and the code in line
307-309 are consistent. (i.e. Use either DCHECK or NOTREACHED in both places,
and formatting for both mappings->Transfer() calls should be the same.)

[gunsch, 2015-03-04 01:22:28]

https://codereview.chromium.org/977443002/diff/20001/chromecast/browser/cast_...
File chromecast/browser/cast_content_browser_client.cc (right):

https://codereview.chromium.org/977443002/diff/20001/chromecast/browser/cast_...
chromecast/browser/cast_content_browser_client.cc:287:
base::ScopedFD(pak_with_flags.TakePlatformFile()));
On 2015/03/04 01:18:52, lcwu1 wrote:
> I think it would be cleaner if the code in line 281-287 and the code in line
> 307-309 are consistent. (i.e. Use either DCHECK or NOTREACHED in both places,
> and formatting for both mappings->Transfer() calls should be the same.)

Done.

[gunsch, 2015-03-04 17:19:40]

The CQ bit was checked by gunsch@chromium.org

[gunsch, 2015-03-04 17:19:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org, lcwu@chromium.org
Link to the patchset: https://codereview.chromium.org/977443002/#ps40001 (title:
"style consistency")

[commit-bot: I haz the power, 2015-03-04 17:21:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/977443002/40001

[commit-bot: I haz the power, 2015-03-04 17:24:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-04 17:24:36]

Patchset 3 (id:??) landed as
https://crrev.com/568f43629db2ee7c2121adf576c21e06554d5c2e
Cr-Commit-Position: refs/heads/master@{#319079}