Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 977413003: Revert of Update SkPicture cull rects with RTree information (Closed)

Created:
5 years, 9 months ago by joshualitt
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Update SkPicture cull rects with RTree information (patchset #6 id:140001 of https://codereview.chromium.org/971803002/) Reason for revert: Might be breaking deps roll Original issue's description: > Update SkPicture cull rects with RTree information > > When computed, the RTree for an SkPicture will have a root > bounds that reflects the best bounding information available, > rather than the best estimate at the time the picture recorder > is created. Given that creators frequently don't know ahead of > time what will be drawn, the RTree bound is often tighter. > > Perf testing on Chrome indicates a small raster performance > advantage. For upcoming painting changes in Chrome the > performance advantage is much larger. > > BUG= > > Committed: https://skia.googlesource.com/skia/+/2dd3b6647dc726f36fd8774b3d0d2e83b493aeac TBR=mtklein@google.com,schenney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://skia.googlesource.com/skia/+/a0865b4620cc614586a5c02f258da2436ed3ab2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -32 lines) Patch
M src/core/SkBBoxHierarchy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkRTree.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkRTree.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M tests/PictureTest.cpp View 3 chunks +4 lines, -7 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of Update SkPicture cull rects with RTree information
5 years, 9 months ago (2015-03-05 20:17:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977413003/1
5 years, 9 months ago (2015-03-05 20:18:26 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 20:18:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a0865b4620cc614586a5c02f258da2436ed3ab2b

Powered by Google App Engine
This is Rietveld 408576698