Disable easter egg on enterprised enrolled devices

chrome/browser/chrome_content_browser_client_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_switches.h"
 #include "url/gurl.h"
 
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/chromeos/chrome_browser_main_chromeos.h"
+#include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
+#include "chrome/browser/chromeos/policy/stub_enterprise_install_attributes.h"
+#include "components/policy/core/common/mock_configuration_policy_provider.h"
+#include "components/policy/core/common/policy_types.h"
+#endif
+
 namespace content {
 
 class ChromeContentBrowserClientBrowserTest : public InProcessBrowserTest {
  public:
   // Returns the last committed navigation entry of the first tab. May be NULL
   // if there is no such entry.
   NavigationEntry* GetLastCommittedEntry() {
     return browser()->tab_strip_model()->GetWebContentsAt(0)->
         GetController().GetLastCommittedEntry();
   }
 
 #if defined(OS_CHROMEOS)
   void SetUpCommandLine(base::CommandLine* command_line) override {
     command_line->AppendSwitch(switches::kDisableAboutInSettings);
   }
+
+ protected:
+  void SetUpInProcessBrowserTestFixture() override {
+    // Set up fake install attributes.
+    scoped_ptr<policy::StubEnterpriseInstallAttributes> attributes(
+        new policy::StubEnterpriseInstallAttributes());
+    attributes->SetDomain("example.com");
+    attributes->SetRegistrationUser("user@example.com");
+    policy::BrowserPolicyConnectorChromeOS::SetInstallAttributesForTesting(
+        attributes.release());
+  }
 #endif
 };
 
 IN_PROC_BROWSER_TEST_F(ChromeContentBrowserClientBrowserTest,
                        UberURLHandler_SettingsPage) {
   const GURL url_short("chrome://settings/");
   const GURL url_long("chrome://chrome/settings/");
 
   ui_test_utils::NavigateToURL(browser(), url_short);
   NavigationEntry* entry = GetLastCommittedEntry();
@@ skipping 51 matching lines @@
   const GURL url(test_server()->GetURL("files/title1.html"));
 
   ui_test_utils::NavigateToURL(browser(), url);
   NavigationEntry* entry = GetLastCommittedEntry();
 
   ASSERT_TRUE(entry != NULL);
   EXPECT_EQ(url, entry->GetURL());
   EXPECT_EQ(url, entry->GetVirtualURL());
 }
 
+#if defined(OS_CHROMEOS)
+// Test that the disable Easter Egg switch is appended if Chrome OS and
+// the device is enterprise enrolled.
+IN_PROC_BROWSER_TEST_F(ChromeContentBrowserClientBrowserTest,
+    ShouldDisableEasterEgg) {
+  const base::CommandLine& browser_command_line =
+      *base::CommandLine::ForCurrentProcess();
+
+  policy::BrowserPolicyConnectorChromeOS* connector =
+      g_browser_process->platform_part()->browser_policy_connector_chromeos();
+  bool is_enterprise_managed = connector->IsEnterpriseManaged();
+
+  EXPECT_TRUE(is_enterprise_managed);
+  EXPECT_TRUE(browser_command_line.HasSwitch(

[Andrew T Wilson (Slow), 2015/03/13 13:44:57]

This will fail, because you aren't setting the switch on the browser command
line, but rather on the command line of any renderers being created.

[edwardjung, 2015/03/13 16:09:06]

Okay understood, so how do I go about getting the renderer view process specific
command line. All the examples I've seen for checking switches uses
CommandLine::ForCurrentProcess(). 

Apologies that my knowledge is terrible in these respect.
   

[Andrew T Wilson (Slow), 2015/03/13 16:52:27]

Great question. I don't write many tests that involve renderer code. The last
test I reviewed that did anything like this was:

https://codereview.chromium.org/964583002/diff/40001/chrome/browser/policy/po...

So, force-open the network error page, then inject some javascript to verify
that the appropriate things happened on the renderer side? Or email chromium-dev
for advice if there's no good way to forcethe network error page to show up?

[edwardjung, 2015/03/16 13:30:59]

I've moved this test to errorpage_browsertests since they were doing something
similar.

+              switches::kDisableDinosaurEasterEgg));
+}
+#endif
+
 }  // namespace content