Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 977273003: Merged https://codereview.chromium.org/922273002/ to M41 (Closed)

Created:
5 years, 9 months ago by sugoi1
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m41
Target Ref:
refs/heads/chrome/m41
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -27 lines) Patch
M gm/yuvtorgbeffect.cpp View 6 chunks +20 lines, -11 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 5 chunks +31 lines, -12 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.cpp View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 19 (10 generated)
sugoi1
https://codereview.chromium.org/977273003/diff/1/src/ports/SkFontHost_FreeType_common.cpp File src/ports/SkFontHost_FreeType_common.cpp (right): https://codereview.chromium.org/977273003/diff/1/src/ports/SkFontHost_FreeType_common.cpp#newcode181 src/ports/SkFontHost_FreeType_common.cpp:181: SkASSERT(dstMask.fBounds.height() == static_cast<int>(srcFTBitmap.rows)); I had to also add this ...
5 years, 9 months ago (2015-03-10 14:58:20 UTC) #2
sugoi1
Ok, it's been merge approved. If I could get another pair of eyes to look ...
5 years, 9 months ago (2015-03-10 20:06:38 UTC) #4
robertphillips
lgtm
5 years, 9 months ago (2015-03-10 20:48:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977273003/1
5 years, 9 months ago (2015-03-10 20:53:35 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true in order for the CQ ...
5 years, 9 months ago (2015-03-10 20:53:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977273003/1
5 years, 9 months ago (2015-03-10 20:57:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977273003/1
5 years, 9 months ago (2015-03-11 11:57:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977273003/1
5 years, 9 months ago (2015-03-11 12:15:25 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 12:15:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/aa7b421902ec33245cb1f4b65d76860187dec7ef

Powered by Google App Engine
This is Rietveld 408576698