Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 977223004: Update mirroring display even if the display configurations that are visible to ash/chrome hasn't c… (Closed)

Created:
5 years, 9 months ago by oshima
Modified:
5 years, 9 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update mirroring display even if the display configurations that are visible to ash/chrome hasn't changed. BUG=450825 R=mukai@chromium.org Committed: https://crrev.com/978e140cfc993655378c883e838dc17a572776b5 Cr-Commit-Position: refs/heads/master@{#319298}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -9 lines) Patch
M ash/display/display_manager.cc View 1 3 chunks +18 lines, -9 lines 4 comments Download
M ash/display/display_manager_unittest.cc View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
oshima
https://codereview.chromium.org/977223004/diff/80001/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/977223004/diff/80001/ash/display/display_manager.cc#newcode1073 ash/display/display_manager.cc:1073: return; This is called from Shell, so we need ...
5 years, 9 months ago (2015-03-05 18:06:15 UTC) #4
Jun Mukai
lgtm https://codereview.chromium.org/977223004/diff/80001/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/977223004/diff/80001/ash/display/display_manager.cc#newcode813 ash/display/display_manager.cc:813: // When changing from software mirroring mode to ...
5 years, 9 months ago (2015-03-05 18:17:28 UTC) #5
oshima
https://codereview.chromium.org/977223004/diff/80001/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/977223004/diff/80001/ash/display/display_manager.cc#newcode813 ash/display/display_manager.cc:813: // When changing from software mirroring mode to sinlge ...
5 years, 9 months ago (2015-03-05 18:38:12 UTC) #6
Jun Mukai
lgtm https://codereview.chromium.org/977223004/diff/80001/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/977223004/diff/80001/ash/display/display_manager.cc#newcode813 ash/display/display_manager.cc:813: // When changing from software mirroring mode to ...
5 years, 9 months ago (2015-03-05 18:42:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977223004/80001
5 years, 9 months ago (2015-03-05 18:52:32 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 9 months ago (2015-03-05 19:25:26 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 19:26:34 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/978e140cfc993655378c883e838dc17a572776b5
Cr-Commit-Position: refs/heads/master@{#319298}

Powered by Google App Engine
This is Rietveld 408576698