Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

Issue 977223003: When target requires a function, propose a function reference, not an invocation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge and remove unnecessary statement Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
index f97b2a1d1c1e138be6326220b9542050aee8022e..15f26b2ffa1b8b8a0f3ddb6ab994f03f6dd9a733 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
@@ -340,4 +340,31 @@ class DartCompletionRequest extends CompletionRequest {
}
return _optype;
}
+
+ /**
+ * Convert all [CompletionSuggestionKind.INVOCATION] suggestions
+ * to [CompletionSuggestionKind.IDENTIFIER] suggestions.
+ */
+ void convertInvocationsToIdentifiers() {
+ for (int index = suggestions.length - 1; index >= 0; --index) {
+ CompletionSuggestion suggestion = suggestions[index];
+ if (suggestion.kind == CompletionSuggestionKind.INVOCATION) {
+ // Create a copy rather than just modifying the existing suggestion
+ // because [DartCompletionCache] may be caching that suggestion
+ // for future completion requests
+ suggestions[index] = new CompletionSuggestion(
+ CompletionSuggestionKind.IDENTIFIER, suggestion.relevance,
+ suggestion.completion, suggestion.selectionOffset,
+ suggestion.selectionLength, suggestion.isDeprecated,
+ suggestion.isPotential,
+ declaringType: suggestion.declaringType,
+ parameterNames: suggestion.parameterNames,
+ parameterTypes: suggestion.parameterTypes,
+ requiredParameterCount: suggestion.requiredParameterCount,
+ hasNamedParameters: suggestion.hasNamedParameters,
+ returnType: suggestion.returnType,
+ element: suggestion.element);
+ }
+ }
+ }
}

Powered by Google App Engine
This is Rietveld 408576698