Issue 977193003: Fix assumption: HttpTransactionFactory::GetCache() may return NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 977193003: Fix assumption: HttpTransactionFactory::GetCache() may return NULL. (Closed)

Created:
5 years, 9 months ago by gunsch

Modified:
5 years, 9 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, derekjchow1

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix assumption: HttpTransactionFactory::GetCache() may return NULL. R=jam@chromium.org BUG=None Committed: https://crrev.com/e668855cd886fe524b7b5edc9397eaeea9e046d4 Cr-Commit-Position: refs/heads/master@{#319196}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	content/browser/web_contents/web_contents_impl.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

gunsch

Interface at https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_transaction_factory.h&q=http_trans&sq=package:chromium&l=1 In Chrome this likely isn't an issue, but on Chromecast this assumption ...

5 years, 9 months ago (2015-03-05 01:05:17 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977193003/1

5 years, 9 months ago (2015-03-05 01:57:37 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-03-05 02:38:42 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e668855cd886fe524b7b5edc9397eaeea9e046d4
Cr-Commit-Position: refs/heads/master@{#319196}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages