Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 977193002: Adding lowbox condition to IsTokenCacheable function. (Closed)

Created:
5 years, 9 months ago by Shrikant Kelkar
Modified:
5 years, 9 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding lowbox condition to IsTokenCacheable function. Problem discovered during PPAPI out of process tests, where it launches multiple processes with different delegates. BUG=455496 R=rvargas,cpu,jschuh Committed: https://crrev.com/5cf7b07fc4fffa4d440761094a015bcebe8f7693 Cr-Commit-Position: refs/heads/master@{#319194}

Patch Set 1 #

Patch Set 2 : Modified comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sandbox/win/src/broker_services.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Shrikant Kelkar
5 years, 9 months ago (2015-03-04 20:52:05 UTC) #1
jschuh
lgtm, but update the comment to mention app container or lowbox token.
5 years, 9 months ago (2015-03-04 23:45:28 UTC) #2
Shrikant Kelkar
On 2015/03/04 23:45:28, jschuh wrote: > lgtm, but update the comment to mention app container ...
5 years, 9 months ago (2015-03-05 00:46:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977193002/20001
5 years, 9 months ago (2015-03-05 00:48:11 UTC) #6
cpu_(ooo_6.6-7.5)
lgtm
5 years, 9 months ago (2015-03-05 00:55:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-05 02:11:23 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 02:12:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5cf7b07fc4fffa4d440761094a015bcebe8f7693
Cr-Commit-Position: refs/heads/master@{#319194}

Powered by Google App Engine
This is Rietveld 408576698