Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 977153002: Fix increment on nullable (Closed)

Created:
5 years, 9 months ago by vsm
Modified:
5 years, 9 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove assignments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -358 lines) Patch
M lib/src/codegen/js_codegen.dart View 1 5 chunks +33 lines, -13 lines 0 comments Download
M test/codegen/expect/BenchmarkBase.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/codegen/expect/DeltaBlue.js View 11 chunks +13 lines, -13 lines 0 comments Download
M test/codegen/expect/dart/_interceptors.js View 10 chunks +10 lines, -10 lines 0 comments Download
M test/codegen/expect/dart/_internal.js View 36 chunks +54 lines, -54 lines 0 comments Download
M test/codegen/expect/dart/_isolate_helper.js View 9 chunks +12 lines, -12 lines 0 comments Download
M test/codegen/expect/dart/_js_helper.js View 33 chunks +38 lines, -38 lines 0 comments Download
M test/codegen/expect/dart/_native_typed_data.js View 4 chunks +4 lines, -4 lines 0 comments Download
M test/codegen/expect/dart/async.js View 6 chunks +8 lines, -8 lines 0 comments Download
M test/codegen/expect/dart/collection.js View 72 chunks +102 lines, -102 lines 0 comments Download
M test/codegen/expect/dart/convert.js View 38 chunks +59 lines, -59 lines 0 comments Download
M test/codegen/expect/dart/core.js View 33 chunks +40 lines, -40 lines 0 comments Download
M test/codegen/expect/dart/isolate.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/sunflower.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
vsm
5 years, 9 months ago (2015-03-04 19:33:27 UTC) #2
Jennifer Messerly
lgtm https://codereview.chromium.org/977153002/diff/1/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/977153002/diff/1/lib/src/codegen/js_codegen.dart#newcode1250 lib/src/codegen/js_codegen.dart:1250: var op = node.operator; I might be tempted ...
5 years, 9 months ago (2015-03-04 20:08:47 UTC) #3
vsm
https://codereview.chromium.org/977153002/diff/1/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/977153002/diff/1/lib/src/codegen/js_codegen.dart#newcode1250 lib/src/codegen/js_codegen.dart:1250: var op = node.operator; On 2015/03/04 20:08:47, John Messerly ...
5 years, 9 months ago (2015-03-04 20:55:56 UTC) #4
vsm
5 years, 9 months ago (2015-03-04 20:56:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f6bbff5a27d6bb8caa24bead641749fed995340c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698