Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 977143002: skia: Add tracing for skia's budget (Closed)

Created:
5 years, 9 months ago by hendrikw
Modified:
5 years, 9 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skia: Add tracing for skia's budget We've run into several places where GPU rasterization slows down a lot, and in some cases, it's due to use reaching skia's budget. This shows a graph of skia's used and free budgeted memory. Committed: https://skia.googlesource.com/skia/+/876c3132d75966829ad58b2f9b2957d50457cc29

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove test code #

Patch Set 3 : remove newline too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/gpu/GrResourceCache.cpp View 1 2 5 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hendrikw
PTAL, let me know what you think.
5 years, 9 months ago (2015-03-04 18:02:52 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/977143002/diff/1/src/gpu/GrResourceCache.cpp File src/gpu/GrResourceCache.cpp (right): https://codereview.chromium.org/977143002/diff/1/src/gpu/GrResourceCache.cpp#newcode106 src/gpu/GrResourceCache.cpp:106: // TRACE_COUNTER2(TRACE_DISABLED_BY_DEFAULT("skia.gpu.cache"), "fBytes", fBytes); what's with this?
5 years, 9 months ago (2015-03-04 18:08:28 UTC) #3
hendrikw
On 2015/03/04 18:08:28, bsalomon wrote: > lgtm > > https://codereview.chromium.org/977143002/diff/1/src/gpu/GrResourceCache.cpp > File src/gpu/GrResourceCache.cpp (right): > ...
5 years, 9 months ago (2015-03-04 18:10:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977143002/40001
5 years, 9 months ago (2015-03-04 18:26:56 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 18:33:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/876c3132d75966829ad58b2f9b2957d50457cc29

Powered by Google App Engine
This is Rietveld 408576698