Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 977123002: Debugger & classes: add debugger tests for classes. (Closed)

Created:
5 years, 9 months ago by marja
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger & classes: add debugger tests for classes. R=dslomov@chromium.org BUG= Committed: https://crrev.com/bb696488040a561c168d01dee2c9d32c30d128a8 Cr-Commit-Position: refs/heads/master@{#27077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M test/mjsunit/debug-scopes.js View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
marja
dslomov@, even if it turned out that CLASS_SCOPE is not the way to go, I ...
5 years, 9 months ago (2015-03-09 10:03:22 UTC) #1
arv (Not doing code reviews)
LGTM This seems useful. Another thing we might want to test is that we have ...
5 years, 9 months ago (2015-03-09 13:51:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977123002/1
5 years, 9 months ago (2015-03-09 14:00:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 14:49:50 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 14:49:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb696488040a561c168d01dee2c9d32c30d128a8
Cr-Commit-Position: refs/heads/master@{#27077}

Powered by Google App Engine
This is Rietveld 408576698