Add fallback implementation to reorderSpinners for pre JB MR2.

Add fallback implementation to reorderSpinners for pre JB MR2.

Prior to the availability of getBestDateTimePattern() the android
framework either used an internal ICU API, which we can't make use of
in chrome, or used getDateFormatOrder() which is only suitable for
numeric dates. This fix duplicates the latter behaviour so at least
we have some chance of being consistent with the (possibly incorrect)
system ordering while simultaneously not crashing.

BUG=463719
Committed: https://crrev.com/bcc3148169963f6e4699559add1410930c87cd30
Cr-Commit-Position: refs/heads/master@{#319311}

[Tobias Sargeant, 2015-03-04 15:48:06]

tobiasjs@chromium.org changed reviewers:
+ aurimas@chromium.org, newt@chromium.org

[newt (away), 2015-03-04 21:18:31]

https://codereview.chromium.org/977103002/diff/1/ui/android/java/src/org/chro...
File ui/android/java/src/org/chromium/ui/picker/TwoFieldDatePicker.java (right):

https://codereview.chromium.org/977103002/diff/1/ui/android/java/src/org/chro...
ui/android/java/src/org/chromium/ui/picker/TwoFieldDatePicker.java:115: //
TODO(tobiasjs): reorderSpinners causes a crash on Android versions before JB MR2
because
remove this TODO

https://codereview.chromium.org/977103002/diff/1/ui/android/java/src/org/chro...
ui/android/java/src/org/chromium/ui/picker/TwoFieldDatePicker.java:126: private
void reorderSpinners() {
add @TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR2) to this method so Android
lint won't complain about the use of an API added after ICS.

https://codereview.chromium.org/977103002/diff/1/ui/android/java/src/org/chro...
ui/android/java/src/org/chromium/ui/picker/TwoFieldDatePicker.java:127: boolean
pos_inserted = false;
nit: use camelCase for java variable names

https://codereview.chromium.org/977103002/diff/1/ui/android/java/src/org/chro...
ui/android/java/src/org/chromium/ui/picker/TwoFieldDatePicker.java:160: if
(order[i] == DateFormat.MONTH) {
I'd use a literal 'M' here and 'y' below as the DateFormat docs recommend:
http://developer.android.com/reference/android/text/format/DateFormat.html#DATE

Otherwise javac will spew deprecation warnings.

[Tobias Sargeant, 2015-03-05 09:37:23]

https://codereview.chromium.org/977103002/diff/1/ui/android/java/src/org/chro...
File ui/android/java/src/org/chromium/ui/picker/TwoFieldDatePicker.java (right):

https://codereview.chromium.org/977103002/diff/1/ui/android/java/src/org/chro...
ui/android/java/src/org/chromium/ui/picker/TwoFieldDatePicker.java:115: //
TODO(tobiasjs): reorderSpinners causes a crash on Android versions before JB MR2
because
On 2015/03/04 21:18:31, newt wrote:
> remove this TODO

Done.

https://codereview.chromium.org/977103002/diff/1/ui/android/java/src/org/chro...
ui/android/java/src/org/chromium/ui/picker/TwoFieldDatePicker.java:126: private
void reorderSpinners() {
On 2015/03/04 21:18:31, newt wrote:
> add @TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR2) to this method so Android
> lint won't complain about the use of an API added after ICS.

Done.

https://codereview.chromium.org/977103002/diff/1/ui/android/java/src/org/chro...
ui/android/java/src/org/chromium/ui/picker/TwoFieldDatePicker.java:127: boolean
pos_inserted = false;
On 2015/03/04 21:18:31, newt wrote:
> nit: use camelCase for java variable names

Done.

https://codereview.chromium.org/977103002/diff/1/ui/android/java/src/org/chro...
ui/android/java/src/org/chromium/ui/picker/TwoFieldDatePicker.java:160: if
(order[i] == DateFormat.MONTH) {
On 2015/03/04 21:18:31, newt wrote:
> I'd use a literal 'M' here and 'y' below as the DateFormat docs recommend:
>
http://developer.android.com/reference/android/text/format/DateFormat.html#DATE
> 
> Otherwise javac will spew deprecation warnings.

Done.

[newt (away), 2015-03-05 19:11:11]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-03-05 19:11:11]

lgtm

[commit-bot: I haz the power, 2015-03-05 19:11:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/977103002/20001

[commit-bot: I haz the power, 2015-03-05 20:05:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-05 20:06:56]

Patchset 2 (id:??) landed as
https://crrev.com/bcc3148169963f6e4699559add1410930c87cd30
Cr-Commit-Position: refs/heads/master@{#319311}