Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 977053002: Rebaseline fast/inline-block/003.html on Mac (Closed)

Created:
5 years, 9 months ago by Daniel Bratell
Modified:
5 years, 9 months ago
Reviewers:
fs, samli
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rebaseline fast/inline-block/003.html on Mac fast/inline-block/003.html fails all the on mac. Maybe it just needs a new baseline. Problem seems to be different top document margins. R=fs@opera.com,samli@chromium.org BUG=463796 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Daniel Bratell
5 years, 9 months ago (2015-03-04 12:34:43 UTC) #1
fs
lgtm Not sure it's the document margin - looks a bit like baseline changes. But ...
5 years, 9 months ago (2015-03-04 13:08:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977053002/1
5 years, 9 months ago (2015-03-04 13:08:57 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 17:28:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191297

Powered by Google App Engine
This is Rietveld 408576698