[Password manager tests] Provide default config values

[Password manager tests] Provide default config values

This CL adds default values to config parameters for running the Python tests of password manager.

It also corrects a typo (parrallel -> parallel).

R=engedy@chromium.org
BUG=463504
Committed: https://crrev.com/13cf260ac3550317329c4cfab41b8c973f634162
Cr-Commit-Position: refs/heads/master@{#319066}

[vabr (Chromium), 2015-03-04 13:04:46]

Patchset #1 (id:1) has been deleted

[vabr (Chromium), 2015-03-04 13:05:25]

Hi Balázs,

Could you please have a look at this?

Thanks!
Vaclav

[engedy, 2015-03-04 13:20:31]

LGTM with nits. The documentation for ConfigParser is not that great, but what
you are doing makes sense to me.

https://codereview.chromium.org/977043003/diff/20001/components/test/data/pas...
File components/test/data/password_manager/automated_tests/run_tests.py (right):

https://codereview.chromium.org/977043003/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/run_tests.py:6: """This
file allows the bots to be easily configure and run the tests.
nit: configured

https://codereview.chromium.org/977043003/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/run_tests.py:9: of the
following structure:
nit: Add newline here.

https://codereview.chromium.org/977043003/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/run_tests.py:187: two
points:
nit: s/points/aspects/

https://codereview.chromium.org/977043003/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/run_tests.py:189: *
Sections get created for the added defaults where needed, they need not
nit: ..., that is, if

https://codereview.chromium.org/977043003/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/run_tests.py:194:
defaults: A dictionary with keys (section_string, option_string) and
Phrasing suggestion: A dictionary mapping (section_string, option_string) pairs
to string values...

[vabr (Chromium), 2015-03-04 13:25:34]

Thanks, Balázs!

I addressed the comments.

Indeed, this file has a lot of maintenance becoming due, including the question
of its placement, adding tests, presubmit linter tests, etc. I plan to make that
happen in the near future.

CQing this CL now.

Thanks!
Vaclav

https://codereview.chromium.org/977043003/diff/20001/components/test/data/pas...
File components/test/data/password_manager/automated_tests/run_tests.py (right):

https://codereview.chromium.org/977043003/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/run_tests.py:6: """This
file allows the bots to be easily configure and run the tests.
On 2015/03/04 13:20:30, engedy wrote:
> nit: configured

Done.

https://codereview.chromium.org/977043003/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/run_tests.py:9: of the
following structure:
On 2015/03/04 13:20:31, engedy wrote:
> nit: Add newline here.

Done.

https://codereview.chromium.org/977043003/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/run_tests.py:187: two
points:
On 2015/03/04 13:20:31, engedy wrote:
> nit: s/points/aspects/

Done.

https://codereview.chromium.org/977043003/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/run_tests.py:189: *
Sections get created for the added defaults where needed, they need not
On 2015/03/04 13:20:31, engedy wrote:
> nit: ..., that is, if

Done.

https://codereview.chromium.org/977043003/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/run_tests.py:194:
defaults: A dictionary with keys (section_string, option_string) and
On 2015/03/04 13:20:30, engedy wrote:
> Phrasing suggestion: A dictionary mapping (section_string, option_string)
pairs
> to string values...

Done.

[vabr (Chromium), 2015-03-04 13:25:48]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2015-03-04 13:25:49]

The patchset sent to the CQ was uploaded after l-g-t-m from engedy@chromium.org
Link to the patchset: https://codereview.chromium.org/977043003/#ps40001 (title:
"Comments addressed")

[commit-bot: I haz the power, 2015-03-04 13:25:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/977043003/40001

[commit-bot: I haz the power, 2015-03-04 14:22:35]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-04 14:23:08]

Patchset 2 (id:??) landed as
https://crrev.com/13cf260ac3550317329c4cfab41b8c973f634162
Cr-Commit-Position: refs/heads/master@{#319066}