Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 977013003: Remove promotion backup case and report OOM instead. (Closed)

Created:
5 years, 9 months ago by Hannes Payer (out of office)
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove promotion backup case and report OOM instead. There are no test cases for this piece of code and it is really hard to test. If this rare case triggers, we are anyway in an OOM situation and would crash probably soon afterwards. BUG= Committed: https://crrev.com/e813afaf127ab80290153ab676dc07212bdc8946 Cr-Commit-Position: refs/heads/master@{#27026}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M src/heap/heap.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +19 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
LGTM. We probably should watch the number of OOM's after this lands.
5 years, 9 months ago (2015-03-04 14:33:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977013003/20001
5 years, 9 months ago (2015-03-05 18:01:45 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-05 18:38:34 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e813afaf127ab80290153ab676dc07212bdc8946 Cr-Commit-Position: refs/heads/master@{#27026}
5 years, 9 months ago (2015-03-05 18:38:45 UTC) #6
ulan
5 years, 8 months ago (2015-04-01 15:37:22 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1050113002/ by ulan@chromium.org.

The reason for reverting is: Spike in OOM crashes: crbug.com/403113.

Powered by Google App Engine
This is Rietveld 408576698