Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 976983003: Enable content_capabilities on dev channel (Closed)

Created:
5 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable content_capabilities on dev channel BUG=463769 R=kalman@chromium.org Committed: https://crrev.com/1e6cad3682e5a5f023a7702540ae7f2a151dd61a Cr-Commit-Position: refs/heads/master@{#319095}

Patch Set 1 #

Total comments: 1

Patch Set 2 : dev -> canary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M extensions/common/api/_manifest_features.json View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ken Rockot(use gerrit already)
5 years, 9 months ago (2015-03-04 04:04:36 UTC) #1
not at google - send to devlin
lgtm but consider canary only. https://codereview.chromium.org/976983003/diff/1/extensions/common/api/_manifest_features.json File extensions/common/api/_manifest_features.json (right): https://codereview.chromium.org/976983003/diff/1/extensions/common/api/_manifest_features.json#newcode96 extensions/common/api/_manifest_features.json:96: "channel": "dev", You could ...
5 years, 9 months ago (2015-03-04 17:37:45 UTC) #2
Ken Rockot(use gerrit already)
Canary it is. Thanks
5 years, 9 months ago (2015-03-04 17:46:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976983003/20001
5 years, 9 months ago (2015-03-04 17:47:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 19:09:37 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 19:10:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e6cad3682e5a5f023a7702540ae7f2a151dd61a
Cr-Commit-Position: refs/heads/master@{#319095}

Powered by Google App Engine
This is Rietveld 408576698