Add '--adb-keys-file $HOME/.android/*.pub' to all bot provision_devices calls.

scripts/slave/recipe_modules/chromium_android/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import glob
 import os
 import re
 import urllib
 
 from infra.libs.infra_types import freeze
 from slave import recipe_api
 
 INSTRUMENTATION_TESTS = freeze([
   {
     'test': 'AndroidWebViewTest',
@@ skipping 336 matching lines @@
       link = ('https://code.google.com/p/chromium/issues/entry?%s' %
         urllib.urlencode(params))
       f.result.presentation.links.update({
         'report a bug': link
       })
       raise
 
   def provision_devices(self, skip_wipe=False, disable_location=False,
                         min_battery_level=None, disable_network=False,
                         disable_java_debug=False, reboot_timeout=None,
-                        **kwargs):
+                        write_adb_keys_files=True, **kwargs):
     args = ['-t', self.m.chromium.c.BUILD_CONFIG]
     if skip_wipe:
       args.append('--skip-wipe')
+    if write_adb_keys_files and glob.glob(os.path.join(os.environ['HOME'],
+                                                       '.android', '*.pub')):

[luqui, 2015/03/04 20:19:44]

If we told it to write the adb keys file, and there is no adb keys file, that
means something is wrong, no?  We should die.

Also you should not use glob directly in recipes -- it will not interact
correctly with expectations.  If you can't write this with existing recipe
module functionality, we need to make that possible.

[friedman1, 2015/03/04 20:49:34]

Why not just [key for key in os.listdir(os.path.join(os.environ['HOME'],
'.android')) if key.endswith('.pub')] and get rid of the glob?

+      args.append('--adb-key-files %s' % os.path.join(os.environ['HOME'],
+                                                      '.android', '*.pub'))
     if disable_location:
       args.append('--disable-location')
     if reboot_timeout is not None:
       assert isinstance(reboot_timeout, int)
       assert reboot_timeout > 0
       args.extend(['--reboot-timeout', reboot_timeout])
     if min_battery_level is not None:
       assert isinstance(min_battery_level, int)
       assert min_battery_level >= 0
       assert min_battery_level <= 100
@@ skipping 355 matching lines @@
 
     self.m.gsutil.upload(
         source=self.coverage_dir.join('coverage_html'),
         bucket='chrome-code-coverage',
         dest=gs_dest,
         args=['-R'],
         name='upload coverage report',
         link_name='Coverage report',
         version='4.7',
         **kwargs)