Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 976903003: Do not cache NSScreens. (Closed)

Created:
5 years, 9 months ago by Avi (use Gerrit)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not cache NSScreens. BUG=463458 TEST=crashes go away Committed: https://crrev.com/2ed940b3a3f9258a029a48160ebf05af279dc23d Cr-Commit-Position: refs/heads/master@{#319076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -51 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 14 chunks +54 lines, -48 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Avi (use Gerrit)
5 years, 9 months ago (2015-03-04 00:34:56 UTC) #2
Alexei Svitkine (slow)
LGTM - thanks for fixing this!
5 years, 9 months ago (2015-03-04 14:33:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976903003/1
5 years, 9 months ago (2015-03-04 16:20:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 17:12:30 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 17:13:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ed940b3a3f9258a029a48160ebf05af279dc23d
Cr-Commit-Position: refs/heads/master@{#319076}

Powered by Google App Engine
This is Rietveld 408576698