Add state to track the individual elements of the virtual frame....

Add state to track the individual elements of the virtual frame.
Currently, all elements are eagerly pushed to and popped from the
actual frame, so they are always in memory.

The code still passes all the v8 and mozilla tests (in debug mode,
asserting that frames match at every CFG merge point).

This change has not yet been ported to ARM.

Committed: http://code.google.com/p/v8/source/detail?r=731

[Erik Corry, 2008-11-11 10:47:05]

LGTM

http://codereview.chromium.org/9769/diff/206/11
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/9769/diff/206/11#newcode158
Line 158: frame_->AllocateLocals(scope_->num_stack_slots());
Should AllocateLocals be called AllocateStackSlots now?

http://codereview.chromium.org/9769/diff/206/8
File src/virtual-frame-ia32.cc (right):

http://codereview.chromium.org/9769/diff/206/8#newcode43
Line 43: elements_(cgen->scope()->num_parameters() + 5),
5?

http://codereview.chromium.org/9769/diff/206/9
File src/virtual-frame-ia32.h (right):

http://codereview.chromium.org/9769/diff/206/9#newcode76
Line 76: void Adjust(int count);
The name Adjust seems mighty generic.  Perhaps AdjustHeight?

http://codereview.chromium.org/9769/diff/206/9#newcode79
Line 79: void Forget(int count);
ForgetElements?

http://codereview.chromium.org/9769/diff/206/9#newcode108
Line 108: ASSERT(0 <= index && index < local_count_);
2 different asserts is nicer here if one is triggered.

http://codereview.chromium.org/9769/diff/206/9#newcode150
Line 150: // emit code to effect the physical frame.  Does not clobber any
registers
effect -> affect

[Kevin Millikin (Chromium), 2008-11-11 11:37:31]

http://codereview.chromium.org/9769/diff/206/11
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/9769/diff/206/11#newcode158
Line 158: frame_->AllocateLocals(scope_->num_stack_slots());
On 2008/11/11 10:47:05, Erik Corry wrote:
> Should AllocateLocals be called AllocateStackSlots now?

Probably.  Changed.

http://codereview.chromium.org/9769/diff/206/8
File src/virtual-frame-ia32.cc (right):

http://codereview.chromium.org/9769/diff/206/8#newcode43
Line 43: elements_(cgen->scope()->num_parameters() + 5),
On 2008/11/11 10:47:05, Erik Corry wrote:
> 5?

You think that needs some explanation :)

http://codereview.chromium.org/9769/diff/206/9
File src/virtual-frame-ia32.h (right):

http://codereview.chromium.org/9769/diff/206/9#newcode76
Line 76: void Adjust(int count);
On 2008/11/11 10:47:05, Erik Corry wrote:
> The name Adjust seems mighty generic.  Perhaps AdjustHeight?

Perhaps.  Eventually its use will be minimized: externally it is "magic" and
shouldn't be needed, internally its overused right now because it happens to
work for pushes that are materialized.

http://codereview.chromium.org/9769/diff/206/9#newcode79
Line 79: void Forget(int count);
On 2008/11/11 10:47:05, Erik Corry wrote:
> ForgetElements?

Maybe.  It will also be minimized, so I'll hold off on trying to find the right
name for it.

http://codereview.chromium.org/9769/diff/206/9#newcode108
Line 108: ASSERT(0 <= index && index < local_count_);
On 2008/11/11 10:47:05, Erik Corry wrote:
> 2 different asserts is nicer here if one is triggered.

Agreed.  Changed.

http://codereview.chromium.org/9769/diff/206/9#newcode150
Line 150: // emit code to effect the physical frame.  Does not clobber any
registers
On 2008/11/11 10:47:05, Erik Corry wrote:
> effect -> affect

Embarassing.