Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 976833002: Revert "Roll Clang 223108:230914" (Closed)

Created:
5 years, 9 months ago by hans
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, dmikurube+clang_chromium.org, eugenis+clang_chromium.org, jam, rickyz+watch_chromium.org, glider+clang_chromium.org, darin-cc_chromium.org, ukai+watch_chromium.org, piman+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Roll Clang 223108:230914" It seems the roll broke Android tests, see crbug.com/463436. Also, fix common.gypi to add a dependency on the Clang version when host_clang is set. We think this might be the reason the breakage didn't show on trybots when the roll landed: the host binaries weren't recompiled with the new Clang version. BUG=444089, 463436 NOTRY=true NOPRESUBMIT=true TBR=jln, jbauman Committed: https://crrev.com/365c5588df97683350ceabef4d8034c0d3faec78 Cr-Commit-Position: refs/heads/master@{#318940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -35 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M tools/clang/blink_gc_plugin/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/Edge.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/test.sh View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/scripts/blink_gc_plugin_flags.sh View 2 chunks +4 lines, -1 line 0 comments Download
M tools/clang/scripts/package.sh View 4 chunks +7 lines, -5 lines 0 comments Download
A tools/clang/scripts/repackage.sh View 1 chunk +67 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.sh View 9 chunks +352 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hans
PTAL.
5 years, 9 months ago (2015-03-03 21:02:34 UTC) #2
Nico
lgtm, thanks
5 years, 9 months ago (2015-03-03 21:05:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976833002/1
5 years, 9 months ago (2015-03-03 21:08:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 21:09:47 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 21:10:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/365c5588df97683350ceabef4d8034c0d3faec78
Cr-Commit-Position: refs/heads/master@{#318940}

Powered by Google App Engine
This is Rietveld 408576698