Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 976823004: Nuke MOJO_APPLICATION_MANAGER_EXPORT. (Closed)

Created:
5 years, 9 months ago by viettrungluu
Modified:
5 years, 9 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -43 lines) Patch
M shell/android/background_application_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M shell/application_manager/application_loader.h View 2 chunks +1 line, -2 lines 0 comments Download
M shell/application_manager/application_manager.h View 4 chunks +6 lines, -7 lines 0 comments Download
D shell/application_manager/application_manager_export.h View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
plz rubberstamp
5 years, 9 months ago (2015-03-03 23:11:22 UTC) #1
jamesr
lgtm
5 years, 9 months ago (2015-03-03 23:14:09 UTC) #2
viettrungluu
5 years, 9 months ago (2015-03-03 23:18:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1649201ff07ed2226d53ce8ca792a895e8d2fce7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698