Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 976823002: Add new test: DownloadTest.TestMultipleDownloadsBubble (Closed)

Created:
5 years, 9 months ago by felt
Modified:
5 years, 9 months ago
Reviewers:
asanka
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new test: DownloadTest.TestMultipleDownloadsBubble This ensures that both infobars and bubbles are tested by creating both DownloadTest.TestMultipleDownloadsInfobar and DownloadTest. TestMultipleDownloadsBubble. The correct UI (infobar or bubble) is forced with a switch. BUG=438758 Committed: https://crrev.com/ff5eb76821e76cb6c90b940249caf3d748e6fbc0 Cr-Commit-Position: refs/heads/master@{#318987} Committed: https://crrev.com/3d63f87a54b716903100441cbcedbcbabbb33060 Cr-Commit-Position: refs/heads/master@{#319164}

Patch Set 1 #

Patch Set 2 : Fix memory leak #

Patch Set 3 : Wait until bubble is shown #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M chrome/browser/download/download_browsertest.cc View 1 2 4 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
felt
asanka, ptal at updated test.
5 years, 9 months ago (2015-03-03 20:51:56 UTC) #2
asanka
lgtm
5 years, 9 months ago (2015-03-03 22:23:18 UTC) #3
felt
On 2015/03/03 22:23:18, asanka wrote: > lgtm fyi, added two lines to prevent a memory ...
5 years, 9 months ago (2015-03-04 00:09:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976823002/40001
5 years, 9 months ago (2015-03-04 00:10:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-04 01:09:19 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ff5eb76821e76cb6c90b940249caf3d748e6fbc0 Cr-Commit-Position: refs/heads/master@{#318987}
5 years, 9 months ago (2015-03-04 01:10:16 UTC) #12
Finnur
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/977863002/ by finnur@chromium.org. ...
5 years, 9 months ago (2015-03-04 08:53:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976823002/60001
5 years, 9 months ago (2015-03-04 23:41:18 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 9 months ago (2015-03-04 23:45:24 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 23:46:14 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3d63f87a54b716903100441cbcedbcbabbb33060
Cr-Commit-Position: refs/heads/master@{#319164}

Powered by Google App Engine
This is Rietveld 408576698