Add a readonly attribute to cr-input.

Add a readonly attribute to cr-input.

R=orenb@chromium.org
BUG=

Committed: https://crrev.com/2555b1b694d2ef01f9ab6c4d99377d06a46bfe63
Cr-Commit-Position: refs/heads/master@{#319187}

[Jeremy Klein, 2015-03-04 20:20:45]

jlklein@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Oren Blasberg, 2015-03-04 20:25:45]

https://codereview.chromium.org/976713007/diff/1/ui/webui/resources/cr_elemen...
File ui/webui/resources/cr_elements/cr_input/cr_input.html (right):

https://codereview.chromium.org/976713007/diff/1/ui/webui/resources/cr_elemen...
ui/webui/resources/cr_elements/cr_input/cr_input.html:19:
required?="{{required}}" readonly?="{{readonly}}" type="{{type}}">
Where does "readonly?" come from? When I search the polymer repo for core-input
for "readonly" I don't get any results.

I just want to understand how this wokrs.

[Jeremy Klein, 2015-03-04 21:13:47]

On 2015/03/04 20:25:45, Oren Blasberg wrote:
>
https://codereview.chromium.org/976713007/diff/1/ui/webui/resources/cr_elemen...
> File ui/webui/resources/cr_elements/cr_input/cr_input.html (right):
> 
>
https://codereview.chromium.org/976713007/diff/1/ui/webui/resources/cr_elemen...
> ui/webui/resources/cr_elements/cr_input/cr_input.html:19:
> required?="{{required}}" readonly?="{{readonly}}" type="{{type}}">
> Where does "readonly?" come from? When I search the polymer repo for
core-input
> for "readonly" I don't get any results.
> 
> I just want to understand how this wokrs.

readonly is a property of normal inputs and core-input extends input:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input

[Oren Blasberg, 2015-03-04 23:19:29]

lgtm

[michaelpg, 2015-03-04 23:55:12]

lgtm but, what is the motivation for this?

[Jeremy Klein, 2015-03-05 00:05:10]

On 2015/03/04 23:55:12, michaelpg wrote:
> lgtm but, what is the motivation for this?

Oren needs this for the Downloads page where it shows a path selection. I
mentioned that I wasn't sure it would continue to be an input because we don't
have the mocks yet, but it seems like a reasonable thing to add anyway.

[Jeremy Klein, 2015-03-05 00:05:14]

The CQ bit was checked by jlklein@chromium.org

[commit-bot: I haz the power, 2015-03-05 00:06:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976713007/1

[commit-bot: I haz the power, 2015-03-05 01:13:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-05 01:14:17]

Patchset 1 (id:??) landed as
https://crrev.com/2555b1b694d2ef01f9ab6c4d99377d06a46bfe63
Cr-Commit-Position: refs/heads/master@{#319187}