Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 976713004: Add thumbnailMetadataItem to GalleryItem. (Closed)

Created:
5 years, 9 months ago by hirono
Modified:
5 years, 9 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add thumbnailMetadataItem to GalleryItem. Previously the thumbnail metadata is obtained as a part of old metadata. The CL adds thumbnailMetadataItem to GalleryItem, and remove old metadata models from Gallery. BUG=410766 TEST=None Committed: https://crrev.com/cf5fff0e7fc1f67739c5624c3ef0619b7641ebb1 Cr-Commit-Position: refs/heads/master@{#319047}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -131 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model.js View 2 chunks +8 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 1 6 chunks +8 lines, -19 lines 1 comment Download
M ui/file_manager/gallery/js/gallery_data_model.js View 4 chunks +5 lines, -14 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_data_model_unittest.js View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_item.js View 7 chunks +32 lines, -56 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_item_unittest.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_item_unittest.js View 1 chunk +16 lines, -21 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_view.js View 4 chunks +5 lines, -5 lines 0 comments Download
M ui/file_manager/gallery/js/mosaic_mode.js View 4 chunks +3 lines, -4 lines 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL, thanks!
5 years, 9 months ago (2015-03-04 09:16:47 UTC) #2
mtomasz
lgtm with some nits https://codereview.chromium.org/976713004/diff/40001/ui/file_manager/gallery/js/gallery.js File ui/file_manager/gallery/js/gallery.js (right): https://codereview.chromium.org/976713004/diff/40001/ui/file_manager/gallery/js/gallery.js#newcode262 ui/file_manager/gallery/js/gallery.js:262: ['imageWidth', 'imageHeight', 'size', 'present']; nit: ...
5 years, 9 months ago (2015-03-04 09:29:59 UTC) #3
hirono
On 2015/03/04 09:29:59, mtomasz wrote: > lgtm with some nits > > https://codereview.chromium.org/976713004/diff/40001/ui/file_manager/gallery/js/gallery.js > File ...
5 years, 9 months ago (2015-03-04 10:00:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976713004/40001
5 years, 9 months ago (2015-03-04 10:01:37 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-04 10:04:46 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 10:05:39 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cf5fff0e7fc1f67739c5624c3ef0619b7641ebb1
Cr-Commit-Position: refs/heads/master@{#319047}

Powered by Google App Engine
This is Rietveld 408576698