src/disassembler.cc - Issue 976623002: Serializer: correctly deal with internal references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/disassembler.cc

Issue 976623002: Serializer: correctly deal with internal references. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fixed ports, disabled context specialization for serializer Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/disassembler.cc

diff --git a/src/disassembler.cc b/src/disassembler.cc

index 36638f551641a8d487f9b6914d6459082b0ebe90..37e0c83f80f7561de32658e22eb25dbd7823ae94 100644

--- a/src/disassembler.cc

+++ b/src/disassembler.cc

@@ -186,7 +186,7 @@ static int DecodeIt(Isolate* isolate, std::ostream* os,

out.AddFormatted(" ;; object: %s", obj_name.get());

} else if (rmode == RelocInfo::EXTERNAL_REFERENCE) {

const char* reference_name =

- ref_encoder.NameOfAddress(relocinfo.target_reference());

+ ref_encoder.NameOfAddress(relocinfo.target_external_reference());

out.AddFormatted(" ;; external reference (%s)", reference_name);

} else if (RelocInfo::IsCodeTarget(rmode)) {

out.AddFormatted(" ;; code:");