Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: src/x87/assembler-x87-inl.h

Issue 976623002: Serializer: correctly deal with internal references. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: argh I keep making mistakes. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 } 148 }
149 if (write_barrier_mode == UPDATE_WRITE_BARRIER && 149 if (write_barrier_mode == UPDATE_WRITE_BARRIER &&
150 host() != NULL && 150 host() != NULL &&
151 target->IsHeapObject()) { 151 target->IsHeapObject()) {
152 host()->GetHeap()->incremental_marking()->RecordWrite( 152 host()->GetHeap()->incremental_marking()->RecordWrite(
153 host(), &Memory::Object_at(pc_), HeapObject::cast(target)); 153 host(), &Memory::Object_at(pc_), HeapObject::cast(target));
154 } 154 }
155 } 155 }
156 156
157 157
158 Address RelocInfo::target_reference() { 158 Address RelocInfo::target_external_reference() {
159 DCHECK(rmode_ == RelocInfo::EXTERNAL_REFERENCE); 159 DCHECK(rmode_ == RelocInfo::EXTERNAL_REFERENCE);
160 return Memory::Address_at(pc_); 160 return Memory::Address_at(pc_);
161 } 161 }
162 162
163 163
164 Address RelocInfo::target_internal_reference() {
165 DCHECK(rmode_ == INTERNAL_REFERENCE);
166 return Memory::Address_at(pc_);
167 }
168
169
170 void RelocInfo::set_target_internal_reference(Address target) {
171 DCHECK(rmode_ == INTERNAL_REFERENCE);
172 Memory::Address_at(pc_) = target;
173 }
174
175
164 Address RelocInfo::target_runtime_entry(Assembler* origin) { 176 Address RelocInfo::target_runtime_entry(Assembler* origin) {
165 DCHECK(IsRuntimeEntry(rmode_)); 177 DCHECK(IsRuntimeEntry(rmode_));
166 return reinterpret_cast<Address>(*reinterpret_cast<int32_t*>(pc_)); 178 return reinterpret_cast<Address>(*reinterpret_cast<int32_t*>(pc_));
167 } 179 }
168 180
169 181
170 void RelocInfo::set_target_runtime_entry(Address target, 182 void RelocInfo::set_target_runtime_entry(Address target,
171 WriteBarrierMode write_barrier_mode, 183 WriteBarrierMode write_barrier_mode,
172 ICacheFlushMode icache_flush_mode) { 184 ICacheFlushMode icache_flush_mode) {
173 DCHECK(IsRuntimeEntry(rmode_)); 185 DCHECK(IsRuntimeEntry(rmode_));
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 574
563 575
564 Operand::Operand(Immediate imm) { 576 Operand::Operand(Immediate imm) {
565 // [disp/r] 577 // [disp/r]
566 set_modrm(0, ebp); 578 set_modrm(0, ebp);
567 set_dispr(imm.x_, imm.rmode_); 579 set_dispr(imm.x_, imm.rmode_);
568 } 580 }
569 } } // namespace v8::internal 581 } } // namespace v8::internal
570 582
571 #endif // V8_X87_ASSEMBLER_X87_INL_H_ 583 #endif // V8_X87_ASSEMBLER_X87_INL_H_
OLDNEW
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698