Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: src/assembler.cc

Issue 976623002: Serializer: correctly deal with internal references. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: argh I keep making mistakes. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/assembler.h ('k') | src/compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 843 matching lines...) Expand 10 before | Expand all | Expand 10 after
854 os << static_cast<const void*>(pc_) << " " << RelocModeName(rmode_); 854 os << static_cast<const void*>(pc_) << " " << RelocModeName(rmode_);
855 if (IsComment(rmode_)) { 855 if (IsComment(rmode_)) {
856 os << " (" << reinterpret_cast<char*>(data_) << ")"; 856 os << " (" << reinterpret_cast<char*>(data_) << ")";
857 } else if (rmode_ == DEOPT_REASON) { 857 } else if (rmode_ == DEOPT_REASON) {
858 os << " (" << Deoptimizer::GetDeoptReason( 858 os << " (" << Deoptimizer::GetDeoptReason(
859 static_cast<Deoptimizer::DeoptReason>(data_)) << ")"; 859 static_cast<Deoptimizer::DeoptReason>(data_)) << ")";
860 } else if (rmode_ == EMBEDDED_OBJECT) { 860 } else if (rmode_ == EMBEDDED_OBJECT) {
861 os << " (" << Brief(target_object()) << ")"; 861 os << " (" << Brief(target_object()) << ")";
862 } else if (rmode_ == EXTERNAL_REFERENCE) { 862 } else if (rmode_ == EXTERNAL_REFERENCE) {
863 ExternalReferenceEncoder ref_encoder(isolate); 863 ExternalReferenceEncoder ref_encoder(isolate);
864 os << " (" << ref_encoder.NameOfAddress(target_reference()) << ") (" 864 os << " (" << ref_encoder.NameOfAddress(target_external_reference())
865 << static_cast<const void*>(target_reference()) << ")"; 865 << ") (" << static_cast<const void*>(target_external_reference())
866 << ")";
866 } else if (IsCodeTarget(rmode_)) { 867 } else if (IsCodeTarget(rmode_)) {
867 Code* code = Code::GetCodeFromTargetAddress(target_address()); 868 Code* code = Code::GetCodeFromTargetAddress(target_address());
868 os << " (" << Code::Kind2String(code->kind()) << ") (" 869 os << " (" << Code::Kind2String(code->kind()) << ") ("
869 << static_cast<const void*>(target_address()) << ")"; 870 << static_cast<const void*>(target_address()) << ")";
870 if (rmode_ == CODE_TARGET_WITH_ID) { 871 if (rmode_ == CODE_TARGET_WITH_ID) {
871 os << " (id=" << static_cast<int>(data_) << ")"; 872 os << " (id=" << static_cast<int>(data_) << ")";
872 } 873 }
873 } else if (IsPosition(rmode_)) { 874 } else if (IsPosition(rmode_)) {
874 os << " (" << data() << ")"; 875 os << " (" << data() << ")";
875 } else if (IsRuntimeEntry(rmode_) && 876 } else if (IsRuntimeEntry(rmode_) &&
(...skipping 805 matching lines...) Expand 10 before | Expand all | Expand 10 after
1681 RecordRelocInfo(RelocInfo::JS_RETURN); 1682 RecordRelocInfo(RelocInfo::JS_RETURN);
1682 } 1683 }
1683 1684
1684 1685
1685 void Assembler::RecordDebugBreakSlot() { 1686 void Assembler::RecordDebugBreakSlot() {
1686 positions_recorder()->WriteRecordedPositions(); 1687 positions_recorder()->WriteRecordedPositions();
1687 EnsureSpace ensure_space(this); 1688 EnsureSpace ensure_space(this);
1688 RecordRelocInfo(RelocInfo::DEBUG_BREAK_SLOT); 1689 RecordRelocInfo(RelocInfo::DEBUG_BREAK_SLOT);
1689 } 1690 }
1690 } } // namespace v8::internal 1691 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/assembler.h ('k') | src/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698