Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: pkg/compiler/lib/src/js/rewrite_async.dart

Issue 976603002: Fix problems with default-cases in async code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/async_await_js_transform_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js/rewrite_async.dart
diff --git a/pkg/compiler/lib/src/js/rewrite_async.dart b/pkg/compiler/lib/src/js/rewrite_async.dart
index 617f860238274510ce3466a84de28bb76c180169..3724b70308f74b62e265ddec266d4ee94da92d82 100644
--- a/pkg/compiler/lib/src/js/rewrite_async.dart
+++ b/pkg/compiler/lib/src/js/rewrite_async.dart
@@ -1305,7 +1305,7 @@ abstract class AsyncRewriterBase extends js.NodeVisitor {
if (clause is js.Case) {
labels[i] = newLabel("case");
clauses.add(new js.Case(clause.expression, gotoAndBreak(labels[i])));
- } else if (i is js.Default) {
+ } else if (clause is js.Default) {
labels[i] = newLabel("default");
clauses.add(new js.Default(gotoAndBreak(labels[i])));
hasDefault = true;
@@ -1315,12 +1315,14 @@ abstract class AsyncRewriterBase extends js.NodeVisitor {
}
i++;
}
+ if (!hasDefault) {
+ clauses.add(new js.Default(gotoAndBreak(after)));
+ }
withExpression(node.key, (js.Expression key) {
addStatement(new js.Switch(key, clauses));
}, store: false);
- if (!hasDefault) {
- addGoto(after);
- }
+
+ addBreak();
}
jumpTargets.add(node);
« no previous file with comments | « no previous file | tests/compiler/dart2js/async_await_js_transform_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698