Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: chrome/browser/ui/app_list/app_list_view_delegate.cc

Issue 976553003: Fix Launcher crash in ChromeOS guest mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile warnings on Linux. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/app_list_view_delegate.cc
diff --git a/chrome/browser/ui/app_list/app_list_view_delegate.cc b/chrome/browser/ui/app_list/app_list_view_delegate.cc
index c40337660723557465cafd412a572d1a3c39a0f2..927f77108bfcee7e692ed7b872ea3904b01be5de 100644
--- a/chrome/browser/ui/app_list/app_list_view_delegate.cc
+++ b/chrome/browser/ui/app_list/app_list_view_delegate.cc
@@ -285,6 +285,12 @@ void AppListViewDelegate::SetProfile(Profile* new_profile) {
return;
}
+ // If we are in guest mode, the new profile should be an incognito profile.
+ // Otherwise, there will be trouble opening links in a browser window (see
+ // http://crbug.com/460437).
+ DCHECK(!profile_->IsGuestSession() || profile_->IsOffTheRecord())
tapted 2015/03/04 05:01:10 perhaps worth noting in the comment that this is t
Matt Giuca 2015/03/04 06:07:05 Done.
+ << "Guest mode must use incognito profile";
+
// TODO(vadimt): Remove ScopedTracker below once crbug.com/431326 is fixed.
tracked_objects::ScopedTracker tracking_profile3(
FROM_HERE_WITH_EXPLICIT_FUNCTION(

Powered by Google App Engine
This is Rietveld 408576698