Fix Launcher crash in ChromeOS guest mode.

chrome/browser/ui/app_list/app_list_controller_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/path_service.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
 #include "chrome/browser/ui/app_list/app_list_service.h"
 #include "chrome/browser/ui/app_list/test/chrome_app_list_test_support.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "ui/app_list/app_list_model.h"
 #include "ui/app_list/app_list_switches.h"
 #include "ui/app_list/search_box_model.h"
 #include "ui/app_list/search_result.h"
 #include "ui/app_list/search_result_observer.h"
 #include "ui/base/models/list_model_observer.h"
 
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/login/chrome_restart_request.h"
+#include "chromeos/chromeos_switches.h"
+
+namespace {
+
+GURL GetGoogleURL() {
+  return GURL("http://www.google.com/");
+}
+
+}  // namespace
+
+#endif  // defined(OS_CHROMEOS)
+
 // Browser Test for AppListController that runs on all platforms supporting
 // app_list.
 typedef InProcessBrowserTest AppListControllerBrowserTest;
 
 // Test the CreateNewWindow function of the controller delegate.
 IN_PROC_BROWSER_TEST_F(AppListControllerBrowserTest, CreateNewWindow) {
   const chrome::HostDesktopType desktop = chrome::GetActiveDesktop();
   AppListService* service = test::GetAppListService();
   AppListControllerDelegate* controller(service->GetControllerDelegate());
   ASSERT_TRUE(controller);
@@ skipping 169 matching lines @@
   // Now uninstall and ensure this browser test observes it.
   UninstallExtension(extension->id());
 
   // Allow async AppSearchProvider::UpdateResults to run.
   base::RunLoop().RunUntilIdle();
 
   EXPECT_FALSE(observed_result_);
   StopWatchingResults();
   service->DismissAppList();
 }
+
+#if defined(OS_CHROMEOS)
+
+class AppListControllerGuestModeBrowserTest : public InProcessBrowserTest {
+ protected:
+  void SetUpCommandLine(base::CommandLine* command_line) override;
+};

[tapted, 2015/03/04 05:01:10]

nit: DISALLOW_COPY_AND_ASSIGN -- you'll need  default constructor

[Matt Giuca, 2015/03/04 06:07:05]

Done.

+
+void AppListControllerGuestModeBrowserTest::SetUpCommandLine(
+    base::CommandLine* command_line) {
+  base::CommandLine command_line_copy = *command_line;
+  command_line_copy.AppendSwitchASCII(chromeos::switches::kLoginProfile,
+                                      "user");

[tapted, 2015/03/04 05:01:10]

"user" -> TestingProfile::kTestUserProfileDir ?

[Matt Giuca, 2015/03/04 06:07:05]

Done.

+  command_line_copy.AppendSwitch(chromeos::switches::kGuestSession);
+  chromeos::GetOffTheRecordCommandLine(GetGoogleURL(), true, command_line_copy,

[tapted, 2015/03/04 05:01:10]

Can `GetOffTheRecordCommandLine` be cut out of the picture using the approach in
c/b/ui/webui/chromeos/guest_modE_options_ui_browsertest.cc?


otherwise....

can you just use a default-constructed `GURL()` ? DeriveCommandLine in
chrome_restart_request.cc seems to handle that. If not: comment for
GetGoogleURL() to say what it does and why it's google.com and not some other
URL like about:blank.    Using google.com in a test seems a bit sus -- I think
bots user some kind of fake DNS thingo that makes for flaky tests.

[Matt Giuca, 2015/03/04 06:07:05]

Yeah, I replaced this with the code from guest_mode_options_ui_browsertest.

I found a lot of different tests that each enter Guest Mode in their own special
way. I liked the GetOffTheRecordCommandLine since it seemed to be abstracting
away some of the details. But nah, not worth it as you say.

+                                       command_line);
+}
+
+// Test creating the initial app list in guest mode.
+IN_PROC_BROWSER_TEST_F(AppListControllerGuestModeBrowserTest, Incognito) {
+  AppListService* service = test::GetAppListService();
+  EXPECT_TRUE(service->GetCurrentAppListProfile());
+
+  service->ShowForProfile(browser()->profile());
+  EXPECT_EQ(browser()->profile(), service->GetCurrentAppListProfile());
+}
+
+#endif  // defined(OS_CHROMEOS)