Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: net/cookies/cookie_monster.h

Issue 976553002: Remove the '--enable-file-cookies' flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/test_blink_web_unit_test_support.cc ('k') | net/cookies/cookie_monster.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_monster.h
diff --git a/net/cookies/cookie_monster.h b/net/cookies/cookie_monster.h
index 5633baf2679c490d5ea0f639cf46d908e291c0f0..73df0040b75a03b6904f22b13768ef1c8eafa145 100644
--- a/net/cookies/cookie_monster.h
+++ b/net/cookies/cookie_monster.h
@@ -210,14 +210,6 @@ class NET_EXPORT CookieMonster : public CookieStore {
// the instance (i.e. as part of the instance initialization process).
void SetCookieableSchemes(const char* const schemes[], size_t num_schemes);
- // Resets the list of cookieable schemes to kDefaultCookieableSchemes with or
- // without 'file' being included.
- //
- // There are some unknowns about how to correctly handle file:// cookies,
- // and our implementation for this is not robust enough. This allows you
- // to enable support, but it should only be used for testing. Bug 1157243.
- void SetEnableFileScheme(bool accept);
-
// Instructs the cookie monster to not delete expired cookies. This is used
// in cases where the cookie monster is used as a data structure to keep
// arbitrary cookies.
@@ -312,6 +304,22 @@ class NET_EXPORT CookieMonster : public CookieStore {
const std::string& name,
const CookieChangedCallback& callback) override;
+#if defined(OS_ANDROID)
+ // Resets the list of cookieable schemes to kDefaultCookieableSchemes with or
+ // without 'file' being included.
+ //
+ // There are some unknowns about how to correctly handle file:// cookies,
+ // and our implementation for this is not robust enough (Bug 1157243).
+ // This allows you to enable support, and is exposed as a public WebView
+ // API ('CookieManager::setAcceptFileSchemeCookies').
+ //
+ // TODO(mkwst): This method will be removed once we can deprecate and remove
+ // the Android WebView 'CookieManager::setAcceptFileSchemeCookies' method.
+ // Until then, this method only has effect on Android, and must not be used
+ // outside a WebView context.
+ void SetEnableFileScheme(bool accept);
+#endif
+
private:
// For queueing the cookie monster calls.
class CookieMonsterTask;
« no previous file with comments | « content/test/test_blink_web_unit_test_support.cc ('k') | net/cookies/cookie_monster.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698