Remove the '--enable-file-cookies' flag.

Remove the '--enable-file-cookies' flag.

Discussed at https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/47jdSKRnbqA.

We can't drop the functionality entirely, as it's exposed as a public method
on Android's WebView, but we can limit the functionality to Android and remove
current callers. That's the approach this patch takes.

BUG=470482
Committed: https://crrev.com/b73bf8aa4e868323e981623f4789dbe0ef16a1b6
Cr-Commit-Position: refs/heads/master@{#322991}

[dmichael (off chromium), 2015-03-23 15:49:53]

dmichael@chromium.org changed reviewers:
+ dmichael@chromium.org

[dmichael (off chromium), 2015-03-23 15:49:55]

chrome/test/ppapi lgtm, though you probably also want to remove it from
content/test/ppapi:
https://code.google.com/p/chromium/codesearch#chromium/src/content/test/ppapi...

We haven't used a cookie for the test result in a long time, but missed removing
the flag. Thanks!

[Mike West, 2015-03-25 10:21:28]

mkwst@chromium.org changed reviewers:
+ erikwright@chromium.org, jochen@chromium.org

[Mike West, 2015-03-25 10:22:00]

Jochen, Erik, would you mind taking a look at this patch?

-mike

[jochen (gone - plz use gerrit), 2015-03-25 12:28:16]

lgtm

[Mike West, 2015-03-26 19:16:58]

On 2015/03/25 at 12:28:16, jochen wrote:
> lgtm

Friendly ping for net/cookies, Erik? Do you have any objections to dropping this
flag, and ifdefing the method out for non-Android platforms?

[Mike West, 2015-03-30 08:46:10]

Ping?

[erikwright (departed), 2015-03-30 14:22:30]

LGTM with nits.

https://codereview.chromium.org/976553002/diff/120001/chrome/browser/browsing...
File chrome/browser/browsing_data/browsing_data_helper.cc (right):

https://codereview.chromium.org/976553002/diff/120001/chrome/browser/browsing...
chrome/browser/browsing_data/browsing_data_helper.cc:7: #include
"base/command_line.h"
no longer required?

https://codereview.chromium.org/976553002/diff/120001/chrome/browser/browsing...
chrome/browser/browsing_data/browsing_data_helper.cc:9: #include
"chrome/common/chrome_switches.h"
ditto

https://codereview.chromium.org/976553002/diff/120001/chrome/browser/browsing...
chrome/browser/browsing_data/browsing_data_helper.cc:10: #include
"chrome/common/url_constants.h"
ditto?

https://codereview.chromium.org/976553002/diff/120001/chrome/browser/history/...
File chrome/browser/history/history_browsertest.cc (right):

https://codereview.chromium.org/976553002/diff/120001/chrome/browser/history/...
chrome/browser/history/history_browsertest.cc:35: const base::FilePath::CharType
kDocRoot[] =
include base/files/file_path.h

https://codereview.chromium.org/976553002/diff/120001/content/browser/net/sql...
File content/browser/net/sqlite_persistent_cookie_store.cc (right):

https://codereview.chromium.org/976553002/diff/120001/content/browser/net/sql...
content/browser/net/sqlite_persistent_cookie_store.cc:15: #include
"base/command_line.h"
remove?

https://codereview.chromium.org/976553002/diff/120001/content/browser/net/sql...
content/browser/net/sqlite_persistent_cookie_store.cc:32: #include
"content/public/common/content_switches.h"
remove?

https://codereview.chromium.org/976553002/diff/120001/content/test/test_blink...
File content/test/test_blink_web_unit_test_support.cc (right):

https://codereview.chromium.org/976553002/diff/120001/content/test/test_blink...
content/test/test_blink_web_unit_test_support.cc:7: #include
"base/command_line.h"
remove?

https://codereview.chromium.org/976553002/diff/120001/content/test/test_blink...
content/test/test_blink_web_unit_test_support.cc:13: #include
"content/public/common/content_switches.h"
remove?

https://codereview.chromium.org/976553002/diff/120001/net/cookies/cookie_mons...
File net/cookies/cookie_monster.h (right):

https://codereview.chromium.org/976553002/diff/120001/net/cookies/cookie_mons...
net/cookies/cookie_monster.h:313: // to enable support, but it should only be
used for testing. Bug 1157243.
Is this still accurate? Is WebView using it for testing or a public API?

[Mike West, 2015-03-31 06:37:54]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-03-31 06:37:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmichael@chromium.org, erikwright@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/976553002/#ps140001
(title: "Nits.")

[commit-bot: I haz the power, 2015-03-31 06:38:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976553002/140001

[commit-bot: I haz the power, 2015-03-31 07:33:59]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-03-31 07:34:54]

Patchset 8 (id:??) landed as
https://crrev.com/b73bf8aa4e868323e981623f4789dbe0ef16a1b6
Cr-Commit-Position: refs/heads/master@{#322991}