Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: chrome/browser/extensions/api/log_private/log_private_api.h

Issue 976483002: Add ability for NetLogLogger to gather data from more than just NetLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/log_private/log_private_api.h
diff --git a/chrome/browser/extensions/api/log_private/log_private_api.h b/chrome/browser/extensions/api/log_private/log_private_api.h
index 4fbeaf8cd136dbea89f6e3b75a4dd5485a88417f..a3314a0a9c2631b7930bc19477410e7d6e05961f 100644
--- a/chrome/browser/extensions/api/log_private/log_private_api.h
+++ b/chrome/browser/extensions/api/log_private/log_private_api.h
@@ -8,6 +8,7 @@
#include <set>
#include <string>
+#include "base/files/scoped_file.h"
#include "base/scoped_observer.h"
#include "chrome/browser/extensions/api/log_private/filter_handler.h"
#include "chrome/browser/extensions/api/log_private/log_parser.h"
@@ -88,14 +89,12 @@ class LogPrivateAPI : public BrowserContextKeyedAPI,
void PostPendingEntries();
void AddEntriesOnUI(scoped_ptr<base::ListValue> value);
- // Initializes a new instance of net::NetLogLogger and passes it back via
- // |net_logger| param.
- void InitializeNetLogger(const std::string& owner_extension_id,
- net::NetLogLogger** net_logger);
+ // Creates a file for use with a new instance of net::NetLogLogger.
+ void CreateFileForNetLogger(
+ const std::string& owner_extension_id, base::ScopedFILE* file);
// Starts observing network events with a new |net_logger| instance.
- void StartObservingNetEvents(IOThread* io_thread,
- net::NetLogLogger** net_logger);
+ void StartObservingNetEvents(IOThread* io_thread, base::ScopedFILE* file);
void MaybeStartNetInternalLogging(const std::string& caller_extension_id,
IOThread* io_thread,
api::log_private::EventSink event_sink);
« no previous file with comments | « no previous file | chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698