Add ability for NetLogLogger to gather data from more than just NetLog

content/shell/browser/shell_net_log.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/browser/shell_net_log.h"
 
 #include <stdio.h>
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
+#include "base/files/scoped_file.h"
 #include "base/values.h"
 #include "content/public/common/content_switches.h"
 #include "net/base/net_log_logger.h"
+#include "net/base/net_log_util.h"
 
 namespace content {
 
 namespace {
 
 base::DictionaryValue* GetShellConstants(const std::string& app_name) {
-  base::DictionaryValue* constants_dict = net::NetLogLogger::GetConstants();
+  scoped_ptr<base::DictionaryValue> constants_dict = net::GetNetConstants();
 
   // Add a dictionary with client information
   base::DictionaryValue* dict = new base::DictionaryValue();
 
   dict->SetString("name", app_name);
   dict->SetString(
       "command_line",
       base::CommandLine::ForCurrentProcess()->GetCommandLineString());
 
   constants_dict->Set("clientInfo", dict);
 
-  return constants_dict;
+  return constants_dict.release();
 }
 
 }  // namespace
 
 ShellNetLog::ShellNetLog(const std::string& app_name) {
+  // TODO(mmenke):  Other than a different set of constants, this code is
+  //     identical to code in ChromeNetLog.  Consider merging the code.
   const base::CommandLine* command_line =
       base::CommandLine::ForCurrentProcess();
 
   if (command_line->HasSwitch(switches::kLogNetLog)) {
     base::FilePath log_path =
         command_line->GetSwitchValuePath(switches::kLogNetLog);
     // Much like logging.h, bypass threading restrictions by using fopen
     // directly.  Have to write on a thread that's shutdown to handle events on
     // shutdown properly, and posting events to another thread as they occur
     // would result in an unbounded buffer size, so not much can be gained by
     // doing this on another thread.  It's only used when debugging, so
     // performance is not a big concern.
-    FILE* file = NULL;
+    base::ScopedFILE file;
 #if defined(OS_WIN)
-    file = _wfopen(log_path.value().c_str(), L"w");
+    file.reset(_wfopen(log_path.value().c_str(), L"w"));
 #elif defined(OS_POSIX)
-    file = fopen(log_path.value().c_str(), "w");
+    file.reset(fopen(log_path.value().c_str(), "w"));
 #endif
 
-    if (file == NULL) {
+    if (!file) {
       LOG(ERROR) << "Could not open file " << log_path.value()
                  << " for net logging";
     } else {
       scoped_ptr<base::Value> constants(GetShellConstants(app_name));
-      net_log_logger_.reset(new net::NetLogLogger(file, *constants));
-      net_log_logger_->StartObserving(this);
+      net_log_logger_.reset(new net::NetLogLogger());
+      net_log_logger_->StartObserving(this, file.Pass(), constants.get(),
+                                      nullptr);
     }
   }
 }
 
 ShellNetLog::~ShellNetLog() {
   // Remove the observer we own before we're destroyed.
   if (net_log_logger_)
-    RemoveThreadSafeObserver(net_log_logger_.get());
+    net_log_logger_->StopObserving(nullptr);
 }
 
 }  // namespace content