Chromecast buildfix: CMA renderer has new Initialize interface.

Chromecast buildfix: CMA renderer has new Initialize interface.

See: https://codereview.chromium.org/935243002

R=erickung@chromium.org,lcwu@chromium.org
BUG=None

Committed: https://crrev.com/60492b548ef6897223b22233a7fd28c05c71322c
Cr-Commit-Position: refs/heads/master@{#318809}

[erickung1, 2015-03-03 00:02:22]

On 2015/03/02 23:41:18, gunsch wrote:

lgtm

The cast_shell build fails in other places..... gl_surface_ozone

FAILED: /b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/ui/gl/gl.gl_surface_ozone.o.d -DV8_DEPRECATION_WARNINGS
-D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=223108
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_OZONE=1
-DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN
-DENABLE_PRE_SYNC_BACKUP -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS
-DENABLE_MPEG2TS_STREAM_PARSER -DENABLE_BROWSER_CDMS
-DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DDONT_EMBED_BUILD_METADATA
-DLOG_DISABLED=0 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1
-DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_SPELLCHECK=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
-DGL_IMPLEMENTATION -DSK_SUPPORT_GPU=1 -DSK_LEGACY_DRAWPICTURECALLBACK
-DMESA_EGL_NO_X11_HEADERS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0
-DU_STATIC_IMPLEMENTATION -DUSE_LIBPCI=1 -DUSE_NSS=1 -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -D_GLIBCXX_DEBUG=1 -Igen
-I../../third_party/swiftshader/include -I../../third_party/khronos -I../../gpu
-I../.. -I../../skia/config -I../../third_party/skia/src/core
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils -I../../skia/ext
-I../../third_party/mesa/src/include -I../../third_party/icu/source/i18n
-I../../third_party/icu/source/common -fstack-protector
--param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wall
-Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe
-fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang
/b/build/slave/cast_shell/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-weak-ptr-factory-order -Xclang
-plugin-arg-find-bad-constructs -Xclang strict-virtual-specifiers
-fcolor-diagnostics
-B/b/build/slave/cast_shell/build/src/third_party/binutils/Linux_x64/Release/bin
-Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-inconsistent-missing-override -m64 -march=x86-64
-O0 -g -gdwarf-4 -funwind-tables -gsplit-dwarf -Wno-undefined-bool-conversion
-Wno-tautological-undefined-compare -fno-exceptions -fno-rtti
-fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 
-c ../../ui/gl/gl_surface_ozone.cc -o obj/ui/gl/gl.gl_surface_ozone.o
../../ui/gl/gl_surface_ozone.cc:284:9: error: [chromium-style] Classes that are
ref-counted should have explicit destructors that are declared protected or
private.
  class SurfaceImage : public GLImageLinuxDMABuffer {
        ^
../../ui/gl/gl_surface_ozone.cc:284:24: note: [chromium-style] 'SurfaceImage'
inherits from 'gfx::GLImageLinuxDMABuffer' here
  class SurfaceImage : public GLImageLinuxDMABuffer {
                       ^
../../ui/gl/gl_image_linux_dma_buffer.h:13:41: note: [chromium-style]
'GLImageLinuxDMABuffer' inherits from 'gfx::GLImageEGL' here
class GL_EXPORT GLImageLinuxDMABuffer : public GLImageEGL {
                                        ^
../../ui/gl/gl_image_egl.h:13:30: note: [chromium-style] 'GLImageEGL' inherits
from 'gfx::GLImage' here
class GL_EXPORT GLImageEGL : public GLImage {
                             ^
../../ui/gl/gl_image.h:20:27: note: [chromium-style] 'GLImage' inherits from
'base::RefCounted<GLImage>' here
class GL_EXPORT GLImage : public base::RefCounted<GLImage> {
                          ^
1 error generated.

[gunsch, 2015-03-03 00:09:14]

Yes, our build broke two different places in the same changeset. I replied on
the other CL that caused this: https://codereview.chromium.org/938873002/

[lcwu1, 2015-03-03 00:20:34]

lgtm

[gunsch, 2015-03-03 00:24:21]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2015-03-03 00:27:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976473002/1

[commit-bot: I haz the power, 2015-03-03 00:30:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-03 00:30:45]

Patchset 1 (id:??) landed as
https://crrev.com/60492b548ef6897223b22233a7fd28c05c71322c
Cr-Commit-Position: refs/heads/master@{#318809}