Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: ui/accessibility/platform/ax_platform_node_mac.mm

Issue 976403004: MacViews: Fix accessibility hit tests, provide AXTitle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150303-MacViews-Disable-Touch-Tests
Patch Set: tweak comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/cocoa/bridged_native_widget.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/accessibility/platform/ax_platform_node_mac.mm
diff --git a/ui/accessibility/platform/ax_platform_node_mac.mm b/ui/accessibility/platform/ax_platform_node_mac.mm
index 89444bf0c6fc94c35e48945a9e872c6ee53a89c0..1f65af6547909edea6803351c6b6acea8cfa1cf3 100644
--- a/ui/accessibility/platform/ax_platform_node_mac.mm
+++ b/ui/accessibility/platform/ax_platform_node_mac.mm
@@ -244,6 +244,13 @@ RoleMap BuildSubroleMap() {
return [NSValue valueWithSize:self.boundsInScreen.size];
}
+- (NSString*)AXTitle {
+ std::string value;
+ if (node_->GetStringAttribute(ui::AX_ATTR_NAME, &value))
+ return base::SysUTF8ToNSString(value);
+ return nil;
+}
+
// NSAccessibility informal protocol implementation.
- (BOOL)accessibilityIsIgnored {
@@ -263,13 +270,19 @@ RoleMap BuildSubroleMap() {
}
- (NSArray*)accessibilityAttributeNames {
+ // These attributes are required on all accessibility objects.
return @[
NSAccessibilityChildrenAttribute,
NSAccessibilityParentAttribute,
NSAccessibilityPositionAttribute,
NSAccessibilityRoleAttribute,
NSAccessibilitySizeAttribute,
+
+ // Title is required for most elements. Cocoa asks for the value even if it
+ // is omitted here, but won't present it to accessibility APIs without this.
+ NSAccessibilityTitleAttribute,
];
+ // TODO(tapted): Add additional attributes based on role.
}
- (BOOL)accessibilityIsAttributeSettable:(NSString*)attribute {
« no previous file with comments | « no previous file | ui/views/cocoa/bridged_native_widget.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698